Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-10] [A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta #48787

Closed
grgia opened this issue Sep 9, 2024 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@grgia
Copy link
Contributor

grgia commented Sep 9, 2024

image

Project

#47598

Proposal

#47598 (comment)

Issue OwnerCurrent Issue Owner: @abekkala
@grgia grgia added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 9, 2024
@grgia grgia self-assigned this Sep 9, 2024
@grgia grgia added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 9, 2024
Copy link

melvin-bot bot commented Sep 9, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Sep 9, 2024

Triggered auto assignment to @abekkala (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 9, 2024
Copy link

melvin-bot bot commented Sep 9, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Sep 9, 2024

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@fabioh8010
Copy link
Contributor

Hey, I'm Fabio from Callstack, expert agency, and I would like to work on this issue.

@fabioh8010
Copy link
Contributor

Update: Created a Draft PR that is still WIP.

@fabioh8010
Copy link
Contributor

Update: Feature is almost ready, will test it tomorrow and take screenshoots / videos.

@fabioh8010
Copy link
Contributor

Update: I had to switch to other task with higher priority, tomorrow will focus on this one to take the screenshoots / videos and open it to review.

@grgia
Copy link
Contributor Author

grgia commented Sep 17, 2024

Thanks for the updates @fabioh8010, let me know when your PR is ready for a test build

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Sep 17, 2024
@fabioh8010
Copy link
Contributor

@grgia I've opened the PR to review and attached videos / test steps. You'll notice that the Changed files ESLint check is failing -- I will need to convert some files to useOnyx. I will do it in the next days.

@grgia
Copy link
Contributor Author

grgia commented Sep 20, 2024

Update:
Chatted with @fabioh8010 in the PR and we will be doing the following:

  • Add the Create Option to ALL menus, not only the global create menu

[slack]

Copy link

melvin-bot bot commented Oct 2, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Oct 2, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 3, 2024
@melvin-bot melvin-bot bot changed the title [A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta [HOLD for payment 2024-10-10] [A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta Oct 3, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 3, 2024
Copy link

melvin-bot bot commented Oct 3, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-10. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 3, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@fabioh8010] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 3, 2024
@abekkala
Copy link
Contributor

abekkala commented Oct 4, 2024

PAYMENTS SUMMARY FOR OCT 10

  • FIX: @fabioh8010 does not require payment (Contractor)
  • PR REVIEW: @fedirjh [$250, if no regressions] payment via NewDot

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 9, 2024
@abekkala
Copy link
Contributor

@fabioh8010, can you please propose a regression test for the one? thanks!

Copy link

melvin-bot bot commented Oct 10, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@abekkala
Copy link
Contributor

@fabioh8010 before I can close this can you please propose regression test steps to ensure the new feature will work correctly on production in further releases.
Thanks!

@fabioh8010
Copy link
Contributor

fabioh8010 commented Oct 11, 2024

Hi @abekkala , sorry but I'm not sure if I understand what I am being asked to do. I'm employee from expert agency and this issue was for feature implementation, so I can provide test steps for the feature, is that what you need?

  1. Verify you have the combinedTrackSubmit beta enabled in your account.
  2. Click the FAB to open the Global Create menu, verify there is a Create expense option and there are no Track expense and Submit expense options.
  3. Click the Create expense option to open the page, verify the page's title is Create expense.
  4. Click the Manual tab, insert an amount and click Next to navigate to the next page. Verify the page's title is Submit expense and there is a Just track it button.
  5. Click the Just track it button to navigate to the Track expense confirmation page. Verify the page's title is Track expense. Confirm and verify the expense was tracked.
  6. Repeat steps 4 and 5 for Scan and Distance requests.
  7. Repeat steps 4, 5 and 6 for Manual, Scan and Distance requests, but now submit the expense to someone else instead of tracking it. Verify the confirmation page's title is Submit expense.

cc @grgia

@abekkala
Copy link
Contributor

yes, that's perfect @fabioh8010

@garrettmknight
Copy link
Contributor

$250 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants