-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KDB-589] Rename configuration prefixes and sections #4707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayley-jean
added
the
deprecated
This PR deprecates a feature, function, or configuration option
label
Dec 30, 2024
YoEight
reviewed
Dec 31, 2024
hayley-jean
force-pushed
the
hayley-jean/kdb-589-rename-configuration
branch
from
December 31, 2024 15:32
85e9790
to
347aa07
Compare
…Store/LegacyEventStore
hayley-jean
force-pushed
the
hayley-jean/kdb-589-rename-configuration
branch
from
December 31, 2024 15:40
347aa07
to
226411e
Compare
hayley-jean
force-pushed
the
hayley-jean/kdb-589-rename-configuration
branch
from
January 2, 2025 14:00
babf079
to
0b46690
Compare
hayley-jean
force-pushed
the
hayley-jean/kdb-589-rename-configuration
branch
from
January 3, 2025 13:22
9233ee7
to
314adbc
Compare
hayley-jean
force-pushed
the
hayley-jean/kdb-589-rename-configuration
branch
from
January 3, 2025 14:43
314adbc
to
4a04197
Compare
hayley-jean
force-pushed
the
hayley-jean/kdb-589-rename-configuration
branch
from
January 3, 2025 15:08
01b1633
to
b14f470
Compare
hayley-jean
force-pushed
the
hayley-jean/kdb-589-rename-configuration
branch
from
January 3, 2025 15:51
b14f470
to
be14e5f
Compare
hayley-jean
force-pushed
the
hayley-jean/kdb-589-rename-configuration
branch
from
January 9, 2025 12:25
e91a3ed
to
b8c880a
Compare
timothycoleman
previously approved these changes
Jan 9, 2025
timothycoleman
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
This PR contains a breaking change
deprecated
This PR deprecates a feature, function, or configuration option
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename most of the configuration from
EventStore
toKurrentDB
, while still accepting configuration provided withEventStore
prefixes and files. The benefit of using separate ConfigurationProviders for this is that it is easy to discover which options are still using the legacy prefix, and they're logged automatically at startup. e.g.:Changes to configuration options:
EventStore
prefixes and config sections toKurrentDB
.EventStore
prefix and transform the prefix toKurrentDB
:EventStoreEnvironmentVariables*
EventStoreCommandLine*
EventStoreJsonFile*
EventStore
prefix:Changes to default locations:
eventstore
tokurrentdb
.eventstore.conf
tokurrentdb.conf
.EventStoreDefaultLocations*
config provider and source which overrides some default locations if the EventStore locations exist and the KurrentDB locations do not. This only works for the following locations:/etc/kurrentdb/kurrentdb.conf
->/etc/eventstore/eventstore.conf
/var/lib/kurrentdb/
->/var/lib/eventstore/
/var/log/kurrentdb/
->/var/log/eventstore/