Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: header ad banner for coinzilla #1201

Merged
merged 5 commits into from
Aug 18, 2023

Conversation

gamalielhere
Copy link
Contributor

Describe your changes:

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that were changed.

Fixes #issue: (if present)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have removed hard coded strings
  • I have added entry to ./changelog
  • I have added pr label

Leaving hardcoded ad project for coinzilla as I have no access to ENV variables at the moment.
P.S Marking on hold as creating this PR for builds so coinzilla can take a look.

@gamalielhere gamalielhere added ON HOLD This issue / pr is currently on hold feature new feature labels Aug 9, 2023
@gamalielhere gamalielhere added Ready For Review This PR is completed, reviewers can start review process and removed ON HOLD This issue / pr is currently on hold labels Aug 18, 2023
@gamalielhere gamalielhere merged commit d1e69a5 into develop Aug 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/coinzilla-header-ad branch August 18, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature Ready For Review This PR is completed, reviewers can start review process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants