Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add token routes #1171

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Feat/add token routes #1171

merged 5 commits into from
Jun 23, 2023

Conversation

olgakup
Copy link
Contributor

@olgakup olgakup commented Jun 15, 2023 •
edited
Loading

Describe your changes:

  • Adds fav and all routes to tokens view
  • Ensures tab selection is present is respected with route updates on Tx Details, Block Details, Portfolio, Tokens, Token Details

Fixes #issue: (if present)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have removed hard coded strings
  • I have added entry to ./changelog
  • I have added pr label
  • I have commented my code, particularly in hard-to-understand areas

@olgakup olgakup added bug feature new feature labels Jun 15, 2023
@olgakup olgakup marked this pull request as ready for review June 23, 2023 19:14
@olgakup olgakup merged commit 047f584 into develop Jun 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat/add-token-routes branch June 23, 2023 20:10
@olgakup olgakup mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug feature new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olgakup @mew-bot