thanks for reporting. i can't reproduce the error when targeting master and leaflet 1.0.0-beta.2, so i'm tempted to just ask you to upgrade to 2.0.0-beta.6 if the chatter in the console bothers you.

var osm = L.tileLayer('http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png');
var gray = L.esri.basemapLayer('Gray');
var dark = L.esri.basemapLayer('DarkGray');
var topo = L.esri.basemapLayer('Topographic');

var baseMaps = {
  "osm": osm,
  "gray": gray,
  "dark gray": dark,
  "topographic": topo
};

var map = L.map('map', {
    center: [39.73, -104.99],
    zoom: 3
});

L.control.layers(baseMaps).addTo(map);

Hey @jgravois, that behavior was actually breaking the code, not just bothering ;)
But ok, changing to last beta versions of everything (leaflet and esri-leaflet) worked.

Thanks

ok. weird that i didn't see the same thing, but either way, good to know that you were able to upgrade conveniently.

@jgravois reopening this to ask @carrbrpoa a question.

@carrbrpoa What versions of Leaflet/Esri Leaflet were you using that produced the error? I just want to make sure we don't have an error on master or the 1.0.0 version right now.

Hey @patrickarlt. Sorry, I overwritted the plnkr. This is a new plnkr with the versions that produced the error (leaflet 0.7.7 or 0.7.5 (the ones I tryed) and esri-leaflet 1.0.0):

http://plnkr.co/edit/saRmlbilSA6mAIDpgIXI?p=preview

thx @carrbrpoa, I'll figure out what's going on and get a patch in.

Thanks @jgravois assigning to you.

i've got this problem fixed in a branch called container-error. it makes sense to me that i can tag 1.0.1 as a patch directly from my commit without merging to master, and i assume that npm will fold the release in appropriately too but i'll wait a bit just in case anyone has any words of caution.

@jgravois yup. Release process should be.

1. Bump version in package.json
2. Update the changelog
3. Commit and push to container-error

I think right now only I have permissions to do an NPM release unless you also have access to the esri_dev account so I can take it from there once you do those steps.

unless you also have access to the esri_dev account

i've got the keys.

while i was riding my bike to work this morning i thought of one more thing. what do we do if/when we need to release 1.0.2? if i delete my new branch after tagging it will no longer be in the repository tree. should we maintain a long running 1.x branch going forward?

edit: nevermind, i'm an idiot.

1. Update the changelog

just a note that since we aren't actually ever going to merge 1.x bug fixes back into master, the update to the changelog has to happen in a commit in an entirely seperate Pull Request.

i've verified the problem is fixed in 1.0.1. @carrbrpoa thank you so much for taking the time to point out the issue and provide a repro case.

just as an FYI, it was necessary to run the command below to ensure that the patch i tagged isn't considered the 'latest' release on npm

npm dist-tag add esri-leaflet@2.0.0-beta.6 latest

in the future, i'll consider setting a different --tag manually when publishing or adding publishConfig to the package.json.

Thanks for the efforts guys 💯