ElmerGrid, add input checks when reading gmsh msh files. #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntly valid gmsh formats and if ElmerGrid doesn't support the format, print an informative message including how to fix it, and call fatal error. This change enables reading of gmsh format 1 msh files, which wasn't working. Gmsh type 3 msh files are detected and reported as unsupported.
|
Synchronized ElmerGui by copying in the three source files from ElmerGrid. This will update ElmerGui with the fix for parentheses, in addition to the update to gmsh input file checking. |
|
Thanx Rich! Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect currently valid gmsh formats and if ElmerGrid doesn't support the format, print an informative message, including how to fix it, and call fatal error. This change enables reading of gmsh format 1 msh files, which wasn't working before. Gmsh type 3 msh files are detected and reported as unsupported. As before, binary files are detected. This PR is an extension related to Issue #603 and PR #604, where detection and reporting of binary files was added. This completes upgrading reading of current gmsh file formats, so the user will know positively if a format is or is not supported. A small archive with eight test cases is included.
gmsh-all-formats-examples.zip