docs: document bug in safari that caches css and prevents hmr #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I stuck it in network because it made the most sense to me of the existing headers. Let me know if you'd like that put somewhere else or want more background in the description of the issue in the markdown file. |
|
Thanks Kevin! I'll make some light edits after merging, but this looks great! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in an issue opened the other day.
Description 📖
Safari does not respect the combination of
ETagandCache-Control: no-cacheheaders without the use of a cache-busting query string. Thevite_stylesheet_taghelper does not have this cache-busting query string but if you import the CSS directly into the JS, when it gets split out it works.Background 📜
Bug in Safari
The Fix 🔨
We are documenting the behavior to help folks who may get stumped by it. In the issue, another option was linked in the comments as a workaround but that option didn't appear in my version of Safari and I wasn't able to work out how to disable cache. The only other option I've found so far is to manually empty the cache between stylesheet changes which is not a great dev experience.
Screenshots 📷
Not relevant to this change, just light documentation adjustments.