fix: prevent error when using a proc in asset_host (close #202) #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request fixes #202 by ignoring
asset_hostin Rails when configured with aProc.Background 📜
Usually, the asset host will be used as the base for Vite, which is a good default, especially when
asset_hostis configured to target a CDN.Rails allows to use a
Procto dynamically configureasset_host, allowing to return different values depending on thesource, the URL of an asset.Since there's no "right" value to pass to Vite when
asset_hostis aProc, it's better to ignore it, which in most cases would still allow assets to be correctly resolved.In the few cases where this is not desired,
assetHostcan be explicitly configured inconfig/vite.json,config/vite.rb, or via environment variables.