Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup #591

Merged
merged 20 commits into from
Sep 27, 2022
Merged

Minor cleanup #591

merged 20 commits into from
Sep 27, 2022

Conversation

andrykonchin
Copy link
Member

@andrykonchin andrykonchin commented Sep 27, 2022 •
edited
Loading

Changes:

  • fixed #update!/#update methods - handling of a table-specific timestamps option
  • fixed #update_attribute - skip validation
  • return self in some public methods to enable methods chaining
  • updated Readme.md and rubydoc comments
  • minor refactoring
  • run specs on CI against JRuby again

@andrykonchin
Specs: don't skip a spec for .create_table
7988de4
@andrykonchin
Specs: add missing specs and polish existing for setting updated_at
f7bb0a6 
Followup for #525
@andrykonchin
Add link to DynamoDB documentation - types allowed for primary key at…
cf72122 
…tributes
@andrykonchin
Refactoring: remove overriding .table method in Document module
6e210cf
@andrykonchin
Refactoring: Polish #update!, ItemUpdater, #update_item and related s…
58daafa 
…pecs a bit

Followup for #461
@andrykonchin
Support ItemUpdater#delete(String|Symbol)
b41627c 
Followup for #461
@andrykonchin
CI: run tests against JRuby
28e013f 
Also remove a workaround to prevent issue with I18n:
jruby/jruby#6547
@andrykonchin
Spec: change wording - replace 'composing key' by 'range key'
c3c4e3a 
Followup for #511
@andrykonchin
Readme: add warning about associations' limitation - they don't suppo…
c15f8da 
…rt models with compound primary key
@andrykonchin
Readme: added "Related links" section
5e3ed95
@andrykonchin
Refactoring: require 'concurrent/atom' instead of the whole library
62dceae
@andrykonchin
Refactoring: simplify condition in criteria.rb
f73c7b2
@andrykonchin
Refactoring: dirty.rb
0a2c861
@andrykonchin
Refactoring: adapter.rb
1075d0a
@andrykonchin
Comment: describe timestemp-related logic in the .table method
8fd56c3
@andrykonchin
Documentation: mention that operations based on UpdateItem are atomic
2f996a5
@andrykonchin
Skip validation in #update_attribute
9eb4550
@andrykonchin
Return self in some public methods to allow methods chaining
3fcd0ac
@andrykonchin
Fix handling of a table-specific timestamps option in #update!/#upd…
c7c62aa 
…ate methods
@andrykonchin
Readme: fix grammar
02549bc
@andrykonchin andrykonchin merged commit a2805f7 into master Sep 27, 2022
@andrykonchin andrykonchin deleted the minor-cleanup branch September 27, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrykonchin