Raising UnknownAttribute when adding an attribute not in the model #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying the method `write_attribute` to raise an `UnknownAttribute` error if the user tries to write a field that hasn't been defined on the model class Creating a new module, `Dynamoid::Persistence::UpdateValidations`, with a method to validate if a specific attribute is part of a model class Adding tests to validate the new behavior in: - `.upsert` - `.update_fields` - `.update` - `#update` - `#update_attribute` - `#update_attributes`
lib/dynamoid/persistence.rb
Outdated
| @@ -497,6 +498,8 @@ def save(options = {}) | |||
| def update_attributes(attributes) | |||
| attributes.each { |attribute, value| write_attribute(attribute, value) } | |||
| save | |||
| rescue Dynamoid::Errors::UnknownAttribute | |||
| false | |||
There was a problem hiding this comment.
I think it makes sense to follow Rails convention and raise UnknownAttribute exception anyway even in methods without bang.
There was a problem hiding this comment.
Sounds good to me, I'll make the change
|
Looks pretty good 👍 . There is only one issue to discuss. |
|
Good job. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #462
Changes
Modified the method
write_attributeto raise anUnknownAttributeerror if the user tries to write a field that hasn't been defined on the model classCreated a new module,
Dynamoid::Persistence::UpdateValidations, with a method to validate if a specific attribute is part of a model classAdding tests to validate the new behavior in:
.upsert.update_fields.update#update#update_attribute#update_attributes