Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7821:pm-compatibility-fix-test-coverage #15659

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 15, 2024

Purpose

Based on master...saintentropy:Dynamo:FailureCase#diff-a7975ce1cd3828b7bc9a238f4ae9e0e5352d4ab6fba2071899a423ffdf2286ffR320 by @saintentropy

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • craig proposed fixes implemented
  • additional test coverage for -- complex matrices with multiple hosts
    -- fill matrices with min, max and single versions -- precise single version testing (question to devs)

Reviewers

@saintentropy
@QilongTang

FYIs

@achintyabhat
@avidit

- craig proposed fixes implemented
- additional test coverage for
-- complex matrices with multiple hosts
-- fill matrices with min, max and single versions
-- precise single version testing (question to devs)
@dnenov dnenov changed the title pm-compatibility-fix-test-coverage DYN-7826:pm-compatibility-fix-test-coverage Nov 15, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7826

@dnenov dnenov changed the title DYN-7826:pm-compatibility-fix-test-coverage DYN-7821:pm-compatibility-fix-test-coverage Nov 15, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7821

@QilongTang QilongTang added this to the 3.4 milestone Nov 15, 2024
Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang merged commit b43eb6e into DynamoDS:master Nov 15, 2024
28 of 29 checks passed
@QilongTang
Copy link
Contributor

QilongTang commented Nov 15, 2024

@dnenov Can you cherry-pick this? covered in #15664

@QilongTang QilongTang mentioned this pull request Nov 15, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants