Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-7754: filter exclusivity #15630

Merged
merged 2 commits into from
Nov 12, 2024
Merged

DYN-7754: filter exclusivity #15630

merged 2 commits into from
Nov 12, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 11, 2024 •
edited
Loading

Purpose

Adding mutual exclusivity for filters in the Host and Compatibility groups. This change will make it so using filters from one of the groups will disable all filters from the other group, and vice verse.

UI Changes

EhcEZ64lKs

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • host and compatibility filters are now exclusive
  • enables/disables filters from the opposing group
  • tests coverage

Reviewers

@achintyabhat
@zeusongit
@reddyashish

FYIs

@QilongTang

@dnenov
filter exclusivity
4c54b05 
- host and compatibility filters are now exclusive
- enables/disables filters from the opposing group
- tests coverage
@github-actions github-actions bot changed the title filter exclusivity DYN-7754: filter exclusivity Nov 11, 2024
github-actions[bot]
github-actions bot reviewed Nov 11, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7754

@QilongTang
Copy link
Contributor

Build error: D:\a\Dynamo\Dynamo\Dynamo\test\DynamoCoreWpfTests\PackageManager\PackageManagerSearchElementViewModelTests.cs(1385,1): error CS1038: #endregion directive expected [D:\a\Dynamo\Dynamo\Dynamo\test\DynamoCoreWpfTests\DynamoCoreWpfTests.csproj]

@dnenov
Copy link
Collaborator Author

dnenov commented Nov 12, 2024

Build error: D:\a\Dynamo\Dynamo\Dynamo\test\DynamoCoreWpfTests\PackageManager\PackageManagerSearchElementViewModelTests.cs(1385,1): error CS1038: #endregion directive expected [D:\a\Dynamo\Dynamo\Dynamo\test\DynamoCoreWpfTests\DynamoCoreWpfTests.csproj]

Ooops, I don't know where that #endregion went .. added it back now, it should be fine I hope!

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@zeusongit zeusongit merged commit 496183c into DynamoDS:master Nov 12, 2024
24 checks passed
@zeusongit zeusongit added this to the 3.4 milestone Nov 12, 2024
zeusongit pushed a commit to zeusongit/Dynamo that referenced this pull request Nov 12, 2024
@dnenov @zeusongit
DYN-7754: filter exclusivity (DynamoDS#15630)
73d4232
@zeusongit zeusongit mentioned this pull request Nov 12, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@reddyashish reddyashish reddyashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@dnenov @QilongTang @reddyashish @zeusongit