Acoustic wrapper #226
Merged
Acoustic wrapper #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muthuArivoli
requested changes
Oct 10, 2020
| @@ -24,6 +24,7 @@ add_action_files( | |||
| FILES | |||
| AcousticsProcessing.action | |||
| AcousticsGuess.action | |||
| AcousticsWrapperMessage.action | |||
There was a problem hiding this comment.
Just name it as AcousticsWrapper.action
Comment on lines
6
to
7
| import sys | ||
| import os |
There was a problem hiding this comment.
If these imports are not used, then remove them
| import os | ||
|
|
||
|
|
||
| class ServerClientThing: |
There was a problem hiding this comment.
Rename this to something else, perhaps AcousticsWrapper
| self.server.start() | ||
| rospy.spin() | ||
|
|
||
|
|
| self.client_guess.wait_for_server() | ||
| goal_client_guess = AcousticsGuessGoal() | ||
| goal_client_guess.filename = this_goal.filename | ||
| goal_client_guess.samp_f = 625000 |
There was a problem hiding this comment.
Create a constant variable at the top and set this equal to that constant, so we can easily change it
Comment on lines
49
to
51
| goal_client_processing.if_double = True | ||
| goal_client_processing.version = 0 | ||
| goal_client_processing.samp_f = 625000 |
There was a problem hiding this comment.
Set these as constants as well
18 tasks
muthuArivoli
added a commit
that referenced
this pull request
Mar 13, 2021
* acoustic branch * major refactoring * update matplotlib to use agg backend * move action to custom_msgs and finalize scripts * integrated guess * list comp and refactor * Acoustic wrapper (#226) Adds basic implementation for the main wrapper. * data generator (#253) Co-authored-by: Reed Chen <reedchen19@gmail.com> * Saleae integration (#254) * made guess_processing wrapper * updated variable names * got rid of duplicate scripts * did changes according to comments * saleae rough draft * updated saleae.py to have one line command * spelling changes * fix saeleae code and name Co-authored-by: Brandon K Bae <brandon.bae@duke.edu> Co-authored-by: Spammy0607 <71797727+Spammy0607@users.noreply.github.com> * Refactor and redesign various interfaces Refactors the data sim script and the wrapper script for better design. Updates interfaces to include messages on feedback, and return better indicators of success. * allow multiple files for guess * add readme and launch file, update dockerfiles * linting * lint again * final lint * use tuple over list for key in dictionary Co-authored-by: Estelle He <wh103@duke.edu> Co-authored-by: Reed Chen <reed.chen@duke.edu> Co-authored-by: Reed Chen <reedchen19@gmail.com> Co-authored-by: Spammy0607 <71797727+Spammy0607@users.noreply.github.com> Co-authored-by: Brandon K Bae <brandon.bae@duke.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper class that communicates with guess server and processing server