SA1648 throws an exception on delegates that use the <include> tag #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3292 +/- ##
=======================================
Coverage 93.55% 93.55%
=======================================
Files 1017 1017
Lines 109990 110027 +37
Branches 3786 3786
=======================================
+ Hits 102898 102935 +37
Misses 6141 6141
Partials 951 951 |
sharwell
reviewed
Jan 18, 2021
...yzers/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
sharwell
previously approved these changes
Jan 19, 2021
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Outdated
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Outdated
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Outdated
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Had to make a new batch as some suggestions were not included Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
sharwell
approved these changes
Mar 10, 2021
|
Thanks @angelobreuer ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #3291
This PR includes the following changes: