Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: improving examples, adding German example #21

Merged
merged 1 commit into from
Sep 28, 2020
Merged

MINOR: improving examples, adding German example #21

merged 1 commit into from
Sep 28, 2020

Conversation

spekulatius
Copy link
Contributor

Hey @Donatello-za,

I've been trying out how come keywords are parsed using the script in the example folder. I've noticed a few things along the way. Here are a few minor improvements for the examples:

  • Tweaking path so someone can clone the repo, install composer dependencies and play directly with the examples (from vendor/autoload.php to ../vendor/autoload.php)
  • Improving readability a bit
  • Adding German example in

I hope this works for you.

Cheers,
Peter

@Donatello-za Donatello-za merged commit 6c4bfc3 into Donatello-za:master Sep 28, 2020
@Donatello-za
Copy link
Owner

Hi @spekulatius, thanks for your contribution. I have merged your pull request and made a few minor changes to it. It will be released as v1.0.16.

Thanks again!

@spekulatius
Copy link
Contributor Author

Hey @Donatello-za

awesome, thank you for releasing a new version!

Cheers,
Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants