Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs #63

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Add stubs #63

merged 1 commit into from
Aug 17, 2022

Conversation

kocsismate
Copy link
Collaborator

@kocsismate kocsismate commented Jul 20, 2022

This PR adds stubs (https://externals.io/message/105970) and uses the generated arginfo structures instead of the directly written ones.

ZEND_ARG_INFO(0, N)
ZEND_ARG_INFO(0, r)
ZEND_ARG_INFO(0, p)
ZEND_ARG_INFO(0, keyLength)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the $raw_output param was missing from here

@kocsismate
Copy link
Collaborator Author

@DomBlack I'd like to merge this and my other PR (#64) after the release is done containing the already committed PHP 8 fixes.

@DomBlack
Copy link
Owner

DomBlack commented Aug 2, 2022

Yeah makes sense

@kocsismate kocsismate merged commit bfedea6 into DomBlack:master Aug 17, 2022
@kocsismate kocsismate deleted the stub branch August 17, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants