-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatic check for updates #951
Conversation
It would be great if this modal showed what the version was. |
@szwabodev Hi, I'm getting this error |
I refactored the logic to get image SHA from dokploy service instead of docker image (which was not pulled in your case causing this error). Could you please try now? The error might still occur when dokploy service doesn't exist, but I guess we can assume that this service always exist when dokploy is running, right? |
|
Yeah that's what I asked if we can assume that dokploy service always exists. In base canary version there's similar error when trying to update the server due to missing dokploy service as well. I don't know if there is any possibility that dokploy service doesn't exist in self-hosted mode, except when running it locally which by default doesn't use dokploy service and you need to start it manually like I did for testing this. this is what this command returns on my self-hosted dokploy server: If you want I can simply wrap it with try/catch and return that update is not available in such case? I just wanted to make sure that this service always would exist on self hosted instances. |
ok I added try/catch with default update data fallback, also added a comment with a link to manual installation docs for information how to start service locally to fully test checking updates functionality. |
updateServer
actiongetDokployImageTag
helperScreenshots: