style(preview-deployment): better preview deployment card #938
Conversation
190km
changed the title
| export function PreviewDeploymentCard({ | ||
| appName, | ||
| serverId, | ||
|
|
||
| onDeploymentDelete, | ||
| deploymentId, | ||
| deployments, | ||
|
|
||
| domainId, | ||
| domainHost, | ||
|
|
||
| pullRequestTitle, | ||
| pullRequestUrl, | ||
| isLoading, | ||
| status, | ||
| branch, | ||
| date, | ||
| }: PreviewDeploymentCardProps) { | ||
| return ( |
There was a problem hiding this comment.
I feel is better to just pass the deploymentId and the serverId, and then inside the component use this hook
const { data: previewDeployment } = api.previewDeployment.one.useQuery({ previewDeploymentId: previewDeploymentId, });
In this way we avoid passing too many props, and thus isolate the component in a more elegant way.
There was a problem hiding this comment.
i think we must left onDeploymentDelete because we need the to refetch deployments when deleting one & isLoading on deleting.
There was a problem hiding this comment.
I think we can also abstract and put the handleDeletePreviewDeployment inside the preview-deployment-card.tsx
in this case we reduce the props we need to pass, we remove the isLoading and the onDeploymentDelete prop
|
I preferred to put the component directly into PreviewDeployemtsView, because with a separate component, there were too many problems with the |
Dark
Light