Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add russian translation init #723

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

WoWnik
Copy link
Contributor

@WoWnik WoWnik commented Nov 18, 2024

No description provided.

@WoWnik WoWnik requested a review from Siumauricio as a code owner November 18, 2024 08:50
@TheLetslook
Copy link

@Siumauricio I can confirm that it looks correct

"settings.server.webServer.storage.cleanStoppedContainers": "Очистить остановленные контейнеры",
"settings.server.webServer.storage.cleanDockerBuilder": "Очистить Docker Builder и систему",
"settings.server.webServer.storage.cleanMonitoring": "Очистить мониторинг",
"settings.server.webServer.storage.cleanAll": "Очистить всё",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"settings.server.webServer.storage.cleanAll": "Очистить всё",
"settings.server.webServer.storage.cleanAll": "Очистить все",

😭

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А в слове "тёмная" ничего не смущает?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не заметил) Я бы заменил букву ё на е, никто ее не использует

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Заменил везде

Copy link

@TheLetslook TheLetslook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary, but languages are usually sorted alphabetically

@@ -37,7 +37,7 @@ const appearanceFormSchema = z.object({
theme: z.enum(["light", "dark", "system"], {
required_error: "Please select a theme.",
}),
language: z.enum(["en", "pl", "zh-Hans"], {
language: z.enum(["en", "pl", "zh-Hans", "ru"], {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
language: z.enum(["en", "pl", "zh-Hans", "ru"], {
language: z.enum(["en", "pl", "ru", "zh-Hans"], {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 176 to 179
{ label: "English", value: "en" },
{ label: "Polski", value: "pl" },
{ label: "简体中文", value: "zh-Hans" },
{ label: "Русский", value: "ru" },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ label: "English", value: "en" },
{ label: "Polski", value: "pl" },
{ label: "简体中文", value: "zh-Hans" },
{ label: "Русский", value: "ru" },
{ label: "English", value: "en" },
{ label: "Polski", value: "pl" },
{ label: "Русский", value: "ru" },
{ label: "简体中文", value: "zh-Hans" },

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -2,7 +2,7 @@
module.exports = {
i18n: {
defaultLocale: "en",
locales: ["en", "pl", "zh-Hans"],
locales: ["en", "pl", "zh-Hans", "ru"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
locales: ["en", "pl", "zh-Hans", "ru"],
locales: ["en", "pl", "ru", "zh-Hans"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -71,7 +71,7 @@ export default api.withTRPC(
{
i18n: {
defaultLocale: "en",
locales: ["en", "pl", "zh-Hans"],
locales: ["en", "pl", "zh-Hans", "ru"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
locales: ["en", "pl", "zh-Hans", "ru"],
locales: ["en", "pl", "ru", "zh-Hans"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -1,6 +1,6 @@
import Cookies from "js-cookie";

const SUPPORTED_LOCALES = ["en", "pl", "zh-Hans"] as const;
const SUPPORTED_LOCALES = ["en", "pl", "zh-Hans", "ru"] as const;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const SUPPORTED_LOCALES = ["en", "pl", "zh-Hans", "ru"] as const;
const SUPPORTED_LOCALES = ["en", "pl", "ru", "zh-Hans"] as const;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Siumauricio Siumauricio merged commit 366e881 into Dokploy:canary Nov 20, 2024
@Siumauricio Siumauricio mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants