-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): add i18n support #665
Conversation
@Siumauricio Do you mind if I add i18n support first? |
@Siumauricio Also, do you have any particular preference for the i18n solution? |
@Siumauricio Maybe we can use some tools like https://github.com/WeblateOrg/weblate to handle translations manager 🤔 |
Sounds good to incrementally add translations, how much weight will this add to the final docker image? btw I removed the internationalization in the docs because it was honestly very difficult to keep translations up to date and it was better to stay in English for the time being |
I don't think it will add too much, these are simply JSON files, that said, is there any way we can test it? |
Ill add german once this is merged! |
haha😉. For those contributors who start translating in the first place, they have to complete a basic English Key extraction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! Looks good the PR
This PR aims to add basic i18n support and verify feasibility.
Our goal is to store i18n preferences independently of Next.js internationalization routing, via cookies.