Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add i18n support #665

Merged
merged 12 commits into from
Nov 17, 2024
Merged

Conversation

PaiJi
Copy link
Contributor

@PaiJi PaiJi commented Nov 7, 2024

This PR aims to add basic i18n support and verify feasibility.
Our goal is to store i18n preferences independently of Next.js internationalization routing, via cookies.

@PaiJi
Copy link
Contributor Author

PaiJi commented Nov 7, 2024

@Siumauricio Do you mind if I add i18n support first?
Translation replacements for zh-Hans will be done incrementally later, I'm doing this because given the fast pace of the project's development, a full translation might take too long and make merging difficult.

@PaiJi
Copy link
Contributor Author

PaiJi commented Nov 7, 2024

@Siumauricio Also, do you have any particular preference for the i18n solution?
I use the https://github.com/i18next/next-i18next.

@PaiJi
Copy link
Contributor Author

PaiJi commented Nov 8, 2024

@Siumauricio Maybe we can use some tools like https://github.com/WeblateOrg/weblate to handle translations manager 🤔

@Siumauricio
Copy link
Contributor

Sounds good to incrementally add translations, how much weight will this add to the final docker image?

btw I removed the internationalization in the docs because it was honestly very difficult to keep translations up to date and it was better to stay in English for the time being

@PaiJi
Copy link
Contributor Author

PaiJi commented Nov 10, 2024

Sounds good to incrementally add translations, how much weight will this add to the final docker image?

btw I removed the internationalization in the docs because it was honestly very difficult to keep translations up to date and it was better to stay in English for the time being

I don't think it will add too much, these are simply JSON files, that said, is there any way we can test it?

@Siumauricio Siumauricio marked this pull request as ready for review November 12, 2024 15:02
@Siumauricio Siumauricio self-requested a review as a code owner November 12, 2024 15:02
@mezotv
Copy link
Contributor

mezotv commented Nov 13, 2024

Ill add german once this is merged!

@PaiJi
Copy link
Contributor Author

PaiJi commented Nov 13, 2024

Ill add german once this is merged!

haha😉. For those contributors who start translating in the first place, they have to complete a basic English Key extraction.
Then later contributors who add another language can just copy locale.json

Copy link
Contributor

@Siumauricio Siumauricio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Looks good the PR

@Siumauricio Siumauricio merged commit 3a07d8d into Dokploy:canary Nov 17, 2024
6 checks passed
@PaiJi PaiJi deleted the feat/i18n-support branch November 17, 2024 18:21
@Siumauricio Siumauricio mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants