Prevents "TypeError: Cannot read property 'name' of undefined" #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment certain files throw the following error.
ERR ..js Transformation error
TypeError: Cannot read property 'name' of undefined
at D:/Git/Fusion/UI/codemod.js:32:57
at Array.some (<anonymous>)
I have done some defensive programming and added `prop => prop.key != null &&` into line 32 to prevent this.
snewcomer
approved these changes
Dec 27, 2018
lib/codemod.js
Outdated
| @@ -29,7 +29,7 @@ module.exports = function(file, api, options) { | |||
| source | |||
| .find(j.ObjectExpression) | |||
| .filter(path => { | |||
| return path.node.properties.some(prop => prop.key.name === 'i18n'); | |||
| return path.node.properties.some(prop => prop => prop.key != null && prop.key.name === 'i18n'); | |||
There was a problem hiding this comment.
can we do prop.key && prop.key.name === 'i18n'?
There was a problem hiding this comment.
Good shout! That will catch undefined as well then. I've changed that and committed. Do I need to do anything else now or can you merge?
This change should catch undefined as well as null
Somehow an additional `prop =>` had snuck in
snewcomer
approved these changes
Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment certain files throw the following error.
ERR ..js Transformation error
TypeError: Cannot read property 'name' of undefined
at D:/Git/Fusion/UI/codemod.js:32:57
at Array.some ()
I have done some defensive programming and added
prop => prop.key != null &&into line 32 to prevent this.