Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement voice_channel_effect event #993

Merged
merged 27 commits into from
Nov 13, 2024
Merged

feat: implement voice_channel_effect event #993

merged 27 commits into from
Nov 13, 2024

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Mar 30, 2023 •
edited
Loading

Summary

discord/discord-api-docs#6025

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Mar 30, 2023
Victorsitou
Victorsitou reviewed Mar 30, 2023
View reviewed changes
disnake/raw_models.py Outdated Show resolved Hide resolved
@onerandomusername
Copy link
Member

@shiftinv would you please resolve conflicts?

@onerandomusername
Copy link
Member

onerandomusername commented May 2, 2023 •
edited
Loading

Do we need to wait on the docs PR for this? I'm not quite sure if they plan to ever merge it.

@shiftinv
Copy link
Member Author

shiftinv commented May 2, 2023

Probably, yea. It's not that important of a feature anyway, so personally I'm fine with waiting a little longer.

@shiftinv shiftinv mentioned this pull request Jul 3, 2023
Merged
8 tasks
@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Aug 16, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Nov 13, 2024
@shiftinv shiftinv merged commit 0961c9d into master Nov 13, 2024
29 checks passed
@shiftinv shiftinv deleted the feature/voice-channel-effect-send branch November 13, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victorsitou Victorsitou Victorsitou left review comments

Assignees
No one assigned
Labels
s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.
3 participants
@shiftinv @onerandomusername @Victorsitou