-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typing): improve view type inference of ui decorators #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- view_cls.method now has a properly typed `(Self@V, Item[Self@V], MsgInter)` signature, instead of `(Any, Unknown, MsgInter)` - more importantly, self.method now returns an `Item[Self@V]` with the correctly bound view type, instead of `Item[V_co]`, which was unbound and didn't allow accessing custom attributes on `self.method.view`
shiftinv
added
t: refactor/typing/lint
Refactors, typing changes and/or linting changes
skip news
labels
May 10, 2024
Enegg
reviewed
May 19, 2024
Enegg
reviewed
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adjusts some internal typings to get rid of
Unknown
s in button/select decorators.view_cls.method
now has a properly typed(Self@V, Item[Self@V], MsgInter)
signature, instead of(Any, Unknown, MsgInter)
self.method
now returns anItem[Self@V]
with the correctly bound view type, instead ofItem[V_co]
, which was unbound and didn't allow accessing custom attributes onself.method.view
Additionally widens the accepted input types for the
cls
parameter in decorators to any matching callable, instead of just matching types. The documentation for this hasn't been adjusted (yet?), but there isn't really a reason not to support it.Checklist
pdm lint
pdm pyright