LayoutDocument CanClose is false but still showing close button #196
Comments
|
I think I found the issue in the binding, which does not consider the situation in which a Fortunately, the fix seems to be rather simple as outlined in PR #198 (relevant changes are only @bdachev What's your opinion about this fix? |
|
Dirk, we don't have such case in our software so to be honest I haven't thought of it - sorry my fault. I was wondering if it wouldn't be simpler to just add CanHide property to LayoutDocument class always returning false. But proposed solution seems valid as well and if you have tested and it works as expected please go for it! |
|
I use nuget version 4.50.1 and in that version the bug is still present. |
|
I think I had the same issue. But as I wanted to style the tabs differently I had to copy and change the styles and templates anyway ;) |
It looks like there was stuff done in regard to this with
LayoutAnchorablesbut was the same not fixed inLayoutDocuments?We just updated our Xceed DockingManager, freaked out, cursed a bunch, and then very happily found this fork. It seems to be pretty much a drop-in replacement, but one slight difference I have noticed so far is that
LayoutDocumentswithCanCloseset to false still show the closing "x" where they used to not show an "x" and didn't even take space for it. The "x" doesn't work, it does not close the window, but it's still showing up or leaving a placeholder space for it. If I change some things toLayoutAnchorables the "x" does not show, but there are other issues and theLayoutDocuments seem to work better for my needs. Here's a comparison between the same code with old and new libraries:Old:
New:
This isn't an especially major issue, but knowing our users, they'll all try to click an X if it's there, and complain when it doesn't do anything! I'm happy to just hide it with styling or anything like that as well.
The text was updated successfully, but these errors were encountered: