Add Result.to_json() with examples-based tests #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is motivated by a caching layer I'm working on, where it's helpful to use |
Revert bad change to tox.ini
ezheidtmann
force-pushed
the
add-json-serialization
branch
from
664d5bd to
54499fc
Compare
|
Pushed a fix for the formatting issues identified by CI. The test failure on Windows appears unrelated to this PR. |
|
Thanks for you work. This feature will be in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue type
Summary
Add
Result.to_json(), producing a serializable dictionary which can be used for re-creating the Result later.Calling code must handle serializing
Decimalinstances into JSON numbers (not strings!). We usesimplejsonin tests.