-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve user experience and solve bugs #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Completed a variable name refactoring (from vec_level to emb_level) across multiple files.
- Now the anonymization pipeline is completely separated from the anonymizer object. - Specify a BaseAnonymizer subclass in a config, then import that using !include syntax. Example is shown for GAN anonymizer. - Add a Passthrough anonymizer
- Can convert the .scp files to absolute or relative.
- Makefile installs the environment local to the project folder.
- each libespeak backend instantiation creates a copy of the library. - for some reason previous instances (for each utterance) are not garbage collected. - latest at 1500 or 2000 times of ProsodyExtraction the anonymization pipeline crashes. - As a temporary solution, since ProsodyExtraction does not support `n_processes>1`, we can make different instances share the backend, as long as specs do not change. This also accelerates the prosody extraction. A better fix could be performed to also allow parallel execution but I couldn't see how today.
…mization and evaluation pipelines
- Also fixed a duplicate `save_intermediate` entry in `anon_ims_sttts_pc.yaml`
- BaseAnonymizer and its descendants are now dumpable - Improved documentation - The configs now use !PLACEHOLDER tag from HyperPyYAML instead of the custom class
- Use absolute paths for `asr.sh` invocation - Improved documentation
- Add missing !PLACEHOLDER tags - Define two dataset configs, one for anonymization, one for evaluation (vctk all/common/diff requires separate treatment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple issues at once.
Anonymization:
Evaluation:
General:
README.md