Fix bugs in our CMake dependency declarations #259
Merged
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to compile Derecho on a Fractus node where the LibFabrics and
JSON libraries were not installed system-wide revealed two bugs in our
CMake declarations: (1) The Conf module did not declare its dependency
on nlohmann_json even though conf.cpp includes nlohmann/json.hpp, and
(2) The top-level CMakeLists did not call include_directories() after
calling find_package(libfabric), which is necessary for packages that do
not export CMake targets (the "old way") - we need to both link
${libfabric_LIBRARIES} and include ${libfabric_INCLUDE_DIRS}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to compile Derecho on a Fractus node where the LibFabrics and nlohmann-JSON libraries were not installed system-wide revealed two bugs in our CMake declarations:
${libfabric_LIBRARIES}and include${libfabric_INCLUDE_DIRS}.