Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added dutch translation #269

Merged
merged 2 commits into from
Jul 4, 2022
Merged

feat: Added dutch translation #269

merged 2 commits into from
Jul 4, 2022

Conversation

tejas-nagchandi
Copy link
Contributor

Description

Fixes # 236

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

image

@tejas-nagchandi tejas-nagchandi mentioned this pull request Jul 4, 2022
Open
@tejas-nagchandi
Copy link
Contributor Author

@DenverCoder1, not able to understand the failed check. Let me know if I am doing something incorrectly.

DenverCoder1
DenverCoder1 reviewed Jul 4, 2022
View reviewed changes
src/translations.php Outdated Show resolved Hide resolved
DenverCoder1
DenverCoder1 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again for contributing 🎉

@DenverCoder1 DenverCoder1 changed the title Added dutch translation feat: Added dutch translation Jul 4, 2022
@DenverCoder1 DenverCoder1 merged commit 30da321 into DenverCoder1:main Jul 4, 2022
@tejas-nagchandi tejas-nagchandi deleted the nl branch July 4, 2022 18:48
@tejas-nagchandi tejas-nagchandi mentioned this pull request Jul 28, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tejas-nagchandi @DenverCoder1