Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prettier): all default value should be optional #54114

Merged
merged 2 commits into from
Jul 1, 2021
Merged

fix(prettier): all default value should be optional #54114

merged 2 commits into from
Jul 1, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jun 26, 2021

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 26, 2021 •
edited
Loading

@JounQin Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

@JounQin: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 54114,
  "author": "JounQin",
  "headCommitOid": "58cae418dbe203a6665e1ea35a19af92f883d95f",
  "lastPushDate": "2021-06-26T13:46:55.000Z",
  "lastActivityDate": "2021-07-01T16:35:31.000Z",
  "mergeOfferDate": "2021-07-01T15:44:49.000Z",
  "mergeRequestDate": "2021-07-01T16:35:31.000Z",
  "mergeRequestUser": "JounQin",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "prettier",
      "kind": "edit",
      "files": [
        {
          "path": "types/prettier/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/prettier-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ikatyang",
        "ifiokjr",
        "ffflorian",
        "sosukesuzuki",
        "Shinigami92",
        "kddeisz",
        "thorn0"
      ],
      "addedOwners": [
        "JounQin"
      ],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "orta",
      "date": "2021-07-01T15:44:15.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Shinigami92",
      "date": "2021-06-26T14:27:27.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 869007244,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Edits Owners This PR adds or removes owners Critical package labels Jun 26, 2021
@typescript-bot
Copy link
Contributor

🔔 @ikatyang @ifiokjr @ffflorian @sosukesuzuki @Shinigami92 @kddeisz @thorn0 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Shinigami92
Shinigami92 approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also @JounQin is trustworthy 🙂

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jun 26, 2021
orta
orta approved these changes Jul 1, 2021
View reviewed changes
Copy link
Collaborator

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I checked the JS also

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jul 1, 2021
@typescript-bot
Copy link
Contributor

@JounQin Everything looks good here. Great job! I am ready to merge this PR (at 58cae41) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ikatyang, @ifiokjr, @ffflorian, @sosukesuzuki, @Shinigami92, @kddeisz, @thorn0: you can do this too.)

@JounQin
Copy link
Contributor Author

JounQin commented Jul 1, 2021

Ready to merge

@typescript-bot typescript-bot merged commit cc5ef96 into DefinitelyTyped:master Jul 1, 2021
@JounQin JounQin deleted the feat/prettier branch July 1, 2021 16:36
@typescript-bot
Copy link
Contributor

I just published @types/prettier@2.3.1 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@orta orta orta approved these changes

Assignees
No one assigned
Labels
Critical package Edits Owners This PR adds or removes owners Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JounQin @typescript-bot @orta @Shinigami92