[sinon] allow partial arguments for calledWith #53467
Conversation
Allow partial arguments for calledWith, alwaysCalledWith and neverCalledWith as this is a valid usecase.
|
@Flarna Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes in this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53467,
"author": "Flarna",
"headCommitOid": "918aa7aa62b1a8cf01b20784ee69162a84b8fc19",
"lastPushDate": "2021-05-28T09:24:24.000Z",
"lastActivityDate": "2021-06-02T05:45:21.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"mergeOfferDate": "2021-06-01T21:29:33.000Z",
"mergeRequestDate": "2021-06-02T05:45:21.000Z",
"mergeRequestUser": "Flarna",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "sinon",
"kind": "edit",
"files": [
{
"path": "types/sinon/index.d.ts",
"kind": "definition"
},
{
"path": "types/sinon/sinon-tests.ts",
"kind": "test"
}
],
"owners": [
"mrbigdog2u",
"lumaxis",
"nicojs",
"43081j",
"joshuakgoldberg",
"gjednaszewski",
"johnjesse",
"alecf",
"SimonSchick"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "43081j",
"date": "2021-05-28T21:46:53.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 850284055,
"ciResult": "pass"
} |
|
🔔 @MrBigDog2U @lumaxis @nicojs @43081j @JoshuaKGoldberg @gjednaszewski @johnjesse @alecf @SimonSchick — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
the
Owner Approved
typescript-bot
added
the
Self Merge
|
Ready to merge |
|
I just published |
|
Most likely because I don't use them in my code therefore I haven't noticed it. My PR was triggered by an issues in one of my projects, not by reviewing the whole API. |
|
Thanks - that's what I needed to know. When I have a moment to spare I'll look into submitting a PR on it. |
Allow partial arguments for
calledWith,alwaysCalledWithandneverCalledWithas this is a valid usecase.Only the
xxxExactlyasserts verify all arguments.Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run
npm test <package to test>.Provide a URL to documentation or source code which provides context for the suggested changes: https://sinonjs.org/releases/v11.1.1/assertions/
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.