Upate sinon for @sinonjs/fake-timers #53362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sinonjs/fake-timers@7.1.0 has better types for setImmediate/clearImmediate -- previously they returned `any`, now they return an object type. Update the tests to show that the type is no longer compatible with the `number` that setTimeout returns.
|
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes in this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53362,
"author": "sandersn",
"headCommitOid": "3ec4319fadd86dda783665dd49b9a42a25593f80",
"lastPushDate": "2021-05-24T17:06:36.000Z",
"lastActivityDate": "2021-05-24T17:07:28.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "sinon",
"kind": "edit",
"files": [
{
"path": "types/sinon/sinon-tests.ts",
"kind": "test"
}
],
"owners": [
"mrbigdog2u",
"lumaxis",
"nicojs",
"43081j",
"joshuakgoldberg",
"gjednaszewski",
"johnjesse",
"alecf",
"SimonSchick"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 847199614,
"ciResult": "pass"
} |
|
🔔 @MrBigDog2U @lumaxis @nicojs @43081j @JoshuaKGoldberg @gjednaszewski @johnjesse @alecf @SimonSchick — please review this PR in the next few days. Be sure to explicitly select |
|
Awesome, remember #52377 still exists too. ill rebase it onto master when i can |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sinonjs/fake-timers@7.1.0 has better types for setImmediate/clearImmediate -- previously they returned
any, now they return an object type. Update the tests to show that the type is no longer compatible with thenumberthat setTimeout returns.@43081j you made the change to fake-timers' types, so you might be interested to know that they're now published and DT is updated to handle them.