[README] Add Japanese-translated version #49779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaySoMusician
force-pushed
the
feature/create-readme-ja
branch
from
a9ca33b to
a1f6dcd
Compare
…language versions
MaySoMusician
changed the title
amcasey
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Thanks, @MaySoMusician! This was clearly a lot of work. Since I, unfortunately, do not speak Japanese I just samples bits of the doc with the aid of machine translation. On that basis, it LGTM.
|
@amcasey Thanks for your approval. I hope it'll get merged! |
sasurau4
reviewed
Dec 2, 2020
|
|
||
| 改良したものを世界中に共有する前に、まず自分自身で使ってみてください。 | ||
|
|
||
| > <small>（訳注: 原文における本セクションでの "test"・"testing" は、[テストの実行](#テストの実行)で言及されるような dtslint による自動テストではなく、単に提出しようとしている変更を実際のアプリで試すことを指します。）</small> |
Co-authored-by: Daiki Ihara <sasurau4@gmail.com>
|
@sasurau4 ありがとうございます！ より自然な言い回しだったので apply suggestions しました |
peterblazejewicz
approved these changes
Dec 6, 2020
typescript-bot
added
Other Approved
|
OK cool, I'm merging - I trust @sasurau4 from their TS website work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the PR is still in progress, not ready for mergeNow I just marked this ready for reviewThis PR adds new README translated to Japanese as
README.ja.md. This doesn't make any changes to type definitions.