DH-5149/add delete endpoint and make basellm and alias optional #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjc712
reviewed
Jan 4, 2024
| @@ -176,6 +176,8 @@ def check_file_status(self, file_id: str) -> bool: | |||
| def create_fine_tuning_job(self): | |||
| model_repository = FinetuningsRepository(self.storage) | |||
| model = model_repository.find_by_id(self.fine_tuning_model.id) | |||
| if model.status == "failed": | |||
There was a problem hiding this comment.
Can we set this as a constant?
FinetuningStatus.FAILED.value
jcjc712
approved these changes
Jan 4, 2024
jcjc712
added a commit
that referenced
this pull request
Jan 16, 2024
* Start Kula changes, and new endpoints and remove the old ones * Dh 5073/agents generating sql queries (#276) * DH-5073/text-to-SQL agents * DH-5073/removing the intermediate steps * DH-5073/removing the intermediate steps * DH-5073/update tests * Create services and improve models * DH-5080/refactor_engine_with_new_resources (#277) * DH-5080/refactor_engine_with_new_resources * DH-5080/update the tests * DH-5080/update the testst * DH-5080/updating the evaluatord * Dh 5080/sql generations services (#278) * DH-5080/sql_generations service * DH-5080/reformat with black * DH-5080/removing generator from env example * DH-5082/nl_generations implementation (#279) * DH-5080/removing db connection validation (#280) * Create Prompt service (#281) * DH-5086/endpoints for nl and sql generation (#282) * DH-5085 Re-name golden-records as golden-sqls (#283) * [DH-5068] Add metadata and created_at fields (#284) * [DH-5087] Add Prompts GET endpoints (#285) * DH-5089/fixing_the_new_agent (#286) * DH-5089/fixing_the_new_agent * DH-5089/the get endpoints * DH-5089/refactor with black * DH-5089/renaming golden records * DH-5090/execute sql generation endpoint (#287) * DH-5090/execute sql generation endpoint * DH-5090/do not initiate the repo * DH-5099/save sql_generation on initial then update (#288) * [DH-5088] Add endpoints to update metadata (#289) * DH-5103/nl-generation bug (#290) * [DH-5100] Script to migrate old collections (#291) * Replace PATCH endpoint for PUT (#292) * Fix migrate script (#293) * solving the issue with PUT sql_generations (#294) * solving the issue with PUT sql_generations * reformat * DH-5104/update the fine-tuning metadata (#295) * DH-5104/fixing the issue of finetuning (#297) * Fix datatime responses (#298) * Fix metadata in table-descriptions (#299) * Dh 5104/metadata issue for endpoints (#300) * DH-5104/fixing the golden sqls endpoint * DH-5401/reformat * Replace nl_answer by text (#301) * DH-5110/fixing evalutor issue (#302) * DH-5110/fixing evalutor issue * DH-5110/fixing the 500 error for sql execution * Improve resouces requests (#303) * DH-5109/csv export endpoint (#304) * DH-5094/fix the ARRAY issue (#309) * [DH-5113] Return datetimes with explicit UTC (#311) * Fix migration script (#306) * Dh-5094/reverting_the_fixes (#310) * Dh-5094/reverting_the_fixes * Update the states of the scanner * change the states of the scanner * DH-5094/add exception handling * DH-5094/add exception handling * DH-5094/exception handling * DH-3135/Nulltype handling plus script for scanner (#312) * DH-5137/removing the markdown from queries (#313) * DH-5147/rename the csv endpoint (#314) * DH-5146/add get finetunings to engine (#316) * DH-5149/add delete endpoint and make basellm and alias optional (#317) * DH-5149/add delete endpoint and make basellm and alias optional * DH-5149/update states * DH-5158/update the finetuning statuses (#318) * DH-5158/update the finetuning statuses * finxing the openai states * Add value * DH-5153 Add golden sqls in batches (#319) * DH-5167/update the finetuning statuses (#320) * DH-5167/update the finetuning statuses * DH-5167/refromat with black * Dh 5168/raise exception for not availlable finetuning (#321) * DH-5168/better exception handling for SQL generation * DH-5168/reformat with black * DH-5166/the parser to extract SQL queries (#322) * [DH-5173] Fix table-descriptions PUT endpoint response (#323) * DH-5177/fixing the empty sql queries (#325) * DH-5175/fix_the_status_update_on_engine (#324) * DH-5181/fixing the prompts of fientuning agent (#326) * DH-5184/fix (#327) * [DH-5187] Fix table-descriptions filter by table_name field (#328) * DH-5184/fix the query parameters of finetuning (#329) * DH-5184/fix the query parameters of finetuning * DH-5184/reformat * DH-5204/sql generation error (#330) * DH-5205/chromadb script fix (#331) * [DH-5212] Fix UTC timezone (#332) * Fix datatime fields (#333) * DH-5225/fix the sql injection (#336) * Fix datetime timezone format for the responses (#337) * DH-5232/changing the error message for no sql (#338) * Rename migration file (#339) * Dh 5228/docs for new endpoints (#340) * DH-5228/add finetuning module * DH-5228/add finetuning endpoints * DH-5225/adding the docs for prompts * DH-5228/add nl generations docs * DH-5228/adding the docs for sql generations * DH-5228/add sql generations resource * [DH-5238] Fix migration script (#341) * DH-5225/persist nl generations and return id (#343) * [DH-5117] Sync-schema returns a Table descriptions list (#342) * [DH-5239] Fix datetime format (#344) * DH-5251/avoid question rephrasing (#346) * DH-5253/fix the finetuning get endpoint (#347) --------- Co-authored-by: Mohammadreza Pourreza <71866535+MohammadrezaPourreza@users.noreply.github.com>
DishenWang2023
pushed a commit
that referenced
this pull request
May 7, 2024
* Start Kula changes, and new endpoints and remove the old ones * Dh 5073/agents generating sql queries (#276) * DH-5073/text-to-SQL agents * DH-5073/removing the intermediate steps * DH-5073/removing the intermediate steps * DH-5073/update tests * Create services and improve models * DH-5080/refactor_engine_with_new_resources (#277) * DH-5080/refactor_engine_with_new_resources * DH-5080/update the tests * DH-5080/update the testst * DH-5080/updating the evaluatord * Dh 5080/sql generations services (#278) * DH-5080/sql_generations service * DH-5080/reformat with black * DH-5080/removing generator from env example * DH-5082/nl_generations implementation (#279) * DH-5080/removing db connection validation (#280) * Create Prompt service (#281) * DH-5086/endpoints for nl and sql generation (#282) * DH-5085 Re-name golden-records as golden-sqls (#283) * [DH-5068] Add metadata and created_at fields (#284) * [DH-5087] Add Prompts GET endpoints (#285) * DH-5089/fixing_the_new_agent (#286) * DH-5089/fixing_the_new_agent * DH-5089/the get endpoints * DH-5089/refactor with black * DH-5089/renaming golden records * DH-5090/execute sql generation endpoint (#287) * DH-5090/execute sql generation endpoint * DH-5090/do not initiate the repo * DH-5099/save sql_generation on initial then update (#288) * [DH-5088] Add endpoints to update metadata (#289) * DH-5103/nl-generation bug (#290) * [DH-5100] Script to migrate old collections (#291) * Replace PATCH endpoint for PUT (#292) * Fix migrate script (#293) * solving the issue with PUT sql_generations (#294) * solving the issue with PUT sql_generations * reformat * DH-5104/update the fine-tuning metadata (#295) * DH-5104/fixing the issue of finetuning (#297) * Fix datatime responses (#298) * Fix metadata in table-descriptions (#299) * Dh 5104/metadata issue for endpoints (#300) * DH-5104/fixing the golden sqls endpoint * DH-5401/reformat * Replace nl_answer by text (#301) * DH-5110/fixing evalutor issue (#302) * DH-5110/fixing evalutor issue * DH-5110/fixing the 500 error for sql execution * Improve resouces requests (#303) * DH-5109/csv export endpoint (#304) * DH-5094/fix the ARRAY issue (#309) * [DH-5113] Return datetimes with explicit UTC (#311) * Fix migration script (#306) * Dh-5094/reverting_the_fixes (#310) * Dh-5094/reverting_the_fixes * Update the states of the scanner * change the states of the scanner * DH-5094/add exception handling * DH-5094/add exception handling * DH-5094/exception handling * DH-3135/Nulltype handling plus script for scanner (#312) * DH-5137/removing the markdown from queries (#313) * DH-5147/rename the csv endpoint (#314) * DH-5146/add get finetunings to engine (#316) * DH-5149/add delete endpoint and make basellm and alias optional (#317) * DH-5149/add delete endpoint and make basellm and alias optional * DH-5149/update states * DH-5158/update the finetuning statuses (#318) * DH-5158/update the finetuning statuses * finxing the openai states * Add value * DH-5153 Add golden sqls in batches (#319) * DH-5167/update the finetuning statuses (#320) * DH-5167/update the finetuning statuses * DH-5167/refromat with black * Dh 5168/raise exception for not availlable finetuning (#321) * DH-5168/better exception handling for SQL generation * DH-5168/reformat with black * DH-5166/the parser to extract SQL queries (#322) * [DH-5173] Fix table-descriptions PUT endpoint response (#323) * DH-5177/fixing the empty sql queries (#325) * DH-5175/fix_the_status_update_on_engine (#324) * DH-5181/fixing the prompts of fientuning agent (#326) * DH-5184/fix (#327) * [DH-5187] Fix table-descriptions filter by table_name field (#328) * DH-5184/fix the query parameters of finetuning (#329) * DH-5184/fix the query parameters of finetuning * DH-5184/reformat * DH-5204/sql generation error (#330) * DH-5205/chromadb script fix (#331) * [DH-5212] Fix UTC timezone (#332) * Fix datatime fields (#333) * DH-5225/fix the sql injection (#336) * Fix datetime timezone format for the responses (#337) * DH-5232/changing the error message for no sql (#338) * Rename migration file (#339) * Dh 5228/docs for new endpoints (#340) * DH-5228/add finetuning module * DH-5228/add finetuning endpoints * DH-5225/adding the docs for prompts * DH-5228/add nl generations docs * DH-5228/adding the docs for sql generations * DH-5228/add sql generations resource * [DH-5238] Fix migration script (#341) * DH-5225/persist nl generations and return id (#343) * [DH-5117] Sync-schema returns a Table descriptions list (#342) * [DH-5239] Fix datetime format (#344) * DH-5251/avoid question rephrasing (#346) * DH-5253/fix the finetuning get endpoint (#347) --------- Co-authored-by: Mohammadreza Pourreza <71866535+MohammadrezaPourreza@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.