Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy add_object method does not support signal/image metadata (e.g. ROI) #111

Closed
Charlesreve opened this issue Dec 4, 2024 · 3 comments
Closed

Proxy add_object method does not support signal/image metadata (e.g. ROI) #111

Charlesreve opened this issue Dec 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Charlesreve
Copy link

I am using datalab V0.9.2. I would like to add/modify/delete ROIs to an image already loaded with a macro.
There is no example with ROIs in the tutorials.
I know how to acces the ROIs of my image:

image = proxy.get_object(2)
data = np.array (image.data, copy=True)

and the ROIs are in image.roi.

I have tried :

proxy.add_object(image)

It saves the image with a new number, but without the ROIs.

Could you help ?

charlesreve
@Charlesreve Charlesreve added the documentation Improvements or additions to documentation label Dec 4, 2024
@PierreRaybaut
Copy link
Contributor

PierreRaybaut commented Dec 5, 2024 •
edited
Loading

Hi,

Thanks for the feedback.
This is a limitation of current implementation of the add_object method which is only passing data, title and labels (not metadata).

But, this has just been taken care of: we just added full support for signal and image objects!

Here's the proof:
image
image

Would you be able to wait a few days for this feature?
This will be available in forthcoming v0.18.1.

Otherwise, you may also try the latest version using the main branch which is generally quite stable.

Cheers,
Pierre

@PierreRaybaut PierreRaybaut added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Dec 5, 2024
@PierreRaybaut PierreRaybaut changed the title Region Of Interest Proxy add_object method does not support signal/image metadata (e.g. ROI) Dec 5, 2024
PierreRaybaut added a commit that referenced this issue Dec 5, 2024
@PierreRaybaut
Implement add_object method in LocalProxy, RemoteClient, and RemoteSe…
fdc457b 
…rver for adding SignalObj and ImageObj to DataLab

(following #111)
@Charlesreve
Copy link
Author

Charlesreve commented Dec 6, 2024 via email

@PierreRaybaut
Copy link
Contributor

v0.18.1 has just been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PierreRaybaut @Charlesreve