Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing values to enums #320

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Add missing values to enums #320

merged 3 commits into from
Jun 3, 2020

Conversation

api-clients-generation-pipeline[bot]
Copy link
Contributor

@api-clients-generation-pipeline api-clients-generation-pipeline bot commented Jun 3, 2020 •
edited by gzussa
Loading

This PR fixes missing enums values.

Server side implementation:
Existing endpoint doc: https://docs.datadoghq.com/dashboards/widgets/monitor_summary/ and https://docs.datadoghq.com/dashboards/widgets/service_summary/

@api-clients-generation-pipeline api-clients-generation-pipeline bot requested a review from a team as a code owner June 3, 2020 07:12
@api-clients-generation-pipeline api-clients-generation-pipeline bot added the changelog/Changed Changed features results into a major version bump label Jun 3, 2020
@github-actions github-actions bot added the documentation Documentation related changes label Jun 3, 2020
@gzussa
Copy link
Contributor

gzussa commented Jun 3, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #320 into master will decrease coverage by 0.00%.
The diff coverage is 34.28%.

Impacted Files Coverage Δ
api/v1/datadog/api_hosts.go 72.03% <ø> (ø)
...datadog/model_monitor_summary_widget_definition.go 23.86% <25.00%> (ø)
...pi/v1/datadog/model_widget_monitor_summary_sort.go 33.33% <33.33%> (ø)
...dog/model_widget_service_summary_display_format.go 26.66% <100.00%> (ø)
api/v1/datadog/model_widget_sort.go 33.33% <0.00%> (-6.67%) ⬇️

@gzussa gzussa added changelog/Changed Changed features results into a major version bump and removed changelog/Changed Changed features results into a major version bump labels Jun 3, 2020
@gzussa gzussa merged commit 964e00d into master Jun 3, 2020
@gzussa gzussa deleted the datadog-api-spec/generated/427 branch June 3, 2020 07:30
@gzussa gzussa changed the title Fix enums Add missing values to enums Jun 9, 2020
@gzussa gzussa added the backward-incompatible Warns for backward incompatible changes label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa approved these changes

Assignees
No one assigned
Labels
backward-incompatible Warns for backward incompatible changes changelog/Changed Changed features results into a major version bump documentation Documentation related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gzussa