Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTEL-2314] upgrade otel collector packages to v0.116.0 #32305

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Dec 17, 2024

What does this PR do?

Upgrade otel collector packages to v0.116.0 with inv collector.update

Motivation

Keep otel dependencies up-to-date

@songy23 songy23 added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/opentelemetry OpenTelemetry team qa/no-code-change No code change in Agent code requiring validation labels Dec 17, 2024
@songy23 songy23 added this to the 7.62.0 milestone Dec 17, 2024
@songy23 songy23 requested review from a team as code owners December 17, 2024 15:35
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Dec 17, 2024
Copy link

cit-pr-commenter bot commented Dec 17, 2024

Go Package Import Differences

Baseline: 3763407
Comparison: 2871f89

binaryosarchchange
agentlinuxamd64
+11, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
agentlinuxarm64
+11, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
agentwindowsamd64
+11, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
agentdarwinamd64
+11, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
agentdarwinarm64
+11, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
iot-agentlinuxamd64
+11, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
iot-agentlinuxarm64
+11, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
heroku-agentlinuxamd64
+11, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
cluster-agentlinuxamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
cluster-agentlinuxarm64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
cluster-agent-cloudfoundrylinuxamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
cluster-agent-cloudfoundrylinuxarm64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
dogstatsdlinuxamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
dogstatsdlinuxarm64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
process-agentlinuxamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
process-agentlinuxarm64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
process-agentwindowsamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
process-agentdarwinamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
process-agentdarwinarm64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
heroku-process-agentlinuxamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
security-agentlinuxamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
security-agentlinuxarm64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
security-agentwindowsamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
serverlesslinuxamd64
+11, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
serverlesslinuxarm64
+11, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
system-probelinuxamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
system-probelinuxarm64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
system-probewindowsamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
trace-agentlinuxamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
trace-agentlinuxarm64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
trace-agentwindowsamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
trace-agentdarwinamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
trace-agentdarwinarm64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf
heroku-trace-agentlinuxamd64
+2, -0
+google.golang.org/grpc/balancer/pickfirst/internal
+google.golang.org/grpc/balancer/pickfirst/pickfirstleaf

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 17, 2024

Uncompressed package size comparison

Comparison with ancestor 37634072805c45b57216ee880e06e380257056e7

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.24MB ⚠️ 1188.13MB 1187.89MB 140.00MB
datadog-agent-x86_64-rpm 0.24MB ⚠️ 1197.39MB 1197.15MB 140.00MB
datadog-agent-x86_64-suse 0.24MB ⚠️ 1197.39MB 1197.15MB 140.00MB
datadog-agent-arm64-deb 0.19MB ⚠️ 934.06MB 933.87MB 140.00MB
datadog-agent-aarch64-rpm 0.19MB ⚠️ 943.30MB 943.11MB 140.00MB
datadog-heroku-agent-amd64-deb 0.12MB ⚠️ 504.97MB 504.86MB 70.00MB
datadog-dogstatsd-amd64-deb 0.06MB ⚠️ 78.63MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.06MB ⚠️ 78.71MB 78.64MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.06MB ⚠️ 78.71MB 78.64MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.06MB ⚠️ 113.45MB 113.39MB 10.00MB
datadog-iot-agent-x86_64-suse 0.06MB ⚠️ 113.45MB 113.39MB 10.00MB
datadog-iot-agent-amd64-deb 0.06MB ⚠️ 113.38MB 113.32MB 10.00MB
datadog-dogstatsd-arm64-deb 0.05MB ⚠️ 55.82MB 55.77MB 10.00MB
datadog-iot-agent-arm64-deb 0.05MB ⚠️ 108.84MB 108.79MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.05MB ⚠️ 108.91MB 108.86MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 17, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51608788 --os-family=ubuntu

Note: This applies to commit 2871f89

Copy link

cit-pr-commenter bot commented Dec 17, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7d56df6f-1f45-4f27-a2a4-7c6b1706c7d3

Baseline: c29edf5
Comparison: 49e4ab8
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +1.21 [+1.08, +1.34] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput +0.76 [+0.08, +1.44] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.71 [-0.01, +1.44] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.53 [+0.46, +0.60] 1 Logs
file_tree memory utilization +0.42 [+0.28, +0.55] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.25 [-0.51, +1.02] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.11 [-0.79, +1.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.08 [-0.63, +0.78] 1 Logs
quality_gate_idle memory utilization +0.07 [+0.02, +0.11] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.78, +0.79] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.09, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.05 [-0.52, +0.42] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.99, +0.87] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.11 [-0.75, +0.52] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.46 [-1.23, +0.31] 1 Logs
quality_gate_logs % cpu utilization -0.98 [-3.87, +1.91] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Copy link
Contributor

@jeremy-hanna jeremy-hanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for ASC

Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for agent-apm

internal/tools/go.mod Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants