Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump google.golang.org/protobuf from 1.35.2 to 1.36.0 #32263

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump google.golang.org/protobuf from 1.35.2 to 1.36.0 #32263

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 16, 2024

Bumps google.golang.org/protobuf from 1.35.2 to 1.36.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump google.golang.org/protobuf from 1.35.2 to 1.36.0
e13594d 
Bumps google.golang.org/protobuf from 1.35.2 to 1.36.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Dec 16, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 16, 2024
@github-actions github-actions bot requested review from a team as code owners December 16, 2024 20:43
@cit-pr-commenter cit-pr-commenter
Copy link

Go Package Import Differences

Baseline: 1e3d0a9
Comparison: f5fb28c

binaryosarchchange
agentlinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
agentlinuxarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
agentwindowsamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
agentdarwinamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
agentdarwinarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
iot-agentlinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
iot-agentlinuxarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
heroku-agentlinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
cluster-agentlinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
cluster-agentlinuxarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
cluster-agent-cloudfoundrylinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
cluster-agent-cloudfoundrylinuxarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
dogstatsdlinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
dogstatsdlinuxarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
process-agentlinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
process-agentlinuxarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
process-agentwindowsamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
process-agentdarwinamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
process-agentdarwinarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
heroku-process-agentlinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
security-agentlinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
security-agentlinuxarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
security-agentwindowsamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
serverlesslinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
serverlesslinuxarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
system-probelinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
system-probelinuxarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
system-probewindowsamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
trace-agentlinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
trace-agentlinuxarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
trace-agentwindowsamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
trace-agentdarwinamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
trace-agentdarwinarm64
+1, -0 
+google.golang.org/protobuf/internal/protolazy
heroku-trace-agentlinuxamd64
+1, -0 
+google.golang.org/protobuf/internal/protolazy

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 1e3d0a9e0c7e8dfa74129243154b79062f655b6a

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.97MB ⚠️ 1242.91MB 1241.94MB 140.00MB
datadog-agent-x86_64-suse 0.97MB ⚠️ 1242.91MB 1241.94MB 140.00MB
datadog-agent-amd64-deb 0.97MB ⚠️ 1233.67MB 1232.70MB 140.00MB
datadog-agent-arm64-deb 0.84MB ⚠️ 969.33MB 968.49MB 140.00MB
datadog-agent-aarch64-rpm 0.84MB ⚠️ 978.55MB 977.71MB 140.00MB
datadog-heroku-agent-amd64-deb 0.51MB ⚠️ 505.47MB 504.96MB 70.00MB
datadog-dogstatsd-amd64-deb 0.30MB ⚠️ 78.84MB 78.53MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.30MB ⚠️ 78.91MB 78.61MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.30MB ⚠️ 78.91MB 78.61MB 10.00MB
datadog-iot-agent-arm64-deb 0.25MB ⚠️ 108.98MB 108.72MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.25MB ⚠️ 109.04MB 108.79MB 10.00MB
datadog-iot-agent-amd64-deb 0.25MB ⚠️ 113.51MB 113.26MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.25MB ⚠️ 113.58MB 113.33MB 10.00MB
datadog-iot-agent-x86_64-suse 0.25MB ⚠️ 113.58MB 113.33MB 10.00MB
datadog-dogstatsd-arm64-deb 0.24MB ⚠️ 55.99MB 55.75MB 10.00MB

Decision

⚠️ Warning

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f884df25-0e40-4c42-ac6e-821f4ee89baf

Baseline: 1e3d0a9
Comparison: f5fb28c
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ tcp_syslog_to_blackhole ingress throughput +1.54 [+1.48, +1.60] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization +1.48 [+0.76, +2.20] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.85 [+0.74, +0.95] 1 Logs bounds checks dashboard
➖ file_to_blackhole_1000ms_latency egress throughput +0.19 [-0.58, +0.96] 1 Logs
➖ quality_gate_idle memory utilization +0.03 [-0.01, +0.07] 1 Logs bounds checks dashboard
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.02 [-0.44, +0.48] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.02 [-0.95, +0.98] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.64] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.00 [-0.76, +0.75] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.10] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.84, +0.81] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.05 [-0.93, +0.83] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.07 [-0.85, +0.72] 1 Logs
➖ quality_gate_logs % cpu utilization -0.19 [-3.14, +2.76] 1 Logs
➖ otel_to_otel_logs ingress throughput -0.32 [-0.97, +0.33] 1 Logs
➖ file_tree memory utilization -0.47 [-0.58, -0.36] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 23, 2024

A newer version of google.golang.org/protobuf exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogaca-dd ogaca-dd ogaca-dd approved these changes

@vickenty vickenty vickenty approved these changes

@liustanley liustanley Awaiting requested review from liustanley liustanley was automatically assigned from DataDog/opentelemetry

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency short review PR is simple enough to be reviewed quickly team/triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vickenty @ogaca-dd