Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMLII-2212 Publish FIPS JMX images for e2e tests #32101

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

vickenty
Copy link
Contributor

What does this PR do?

Publish FIPS JMX images for e2e tests

Motivation

Run JMXFetch e2e tests using FIPS images

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@vickenty vickenty added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 12, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 12, 2024
@vickenty vickenty marked this pull request as ready for review December 12, 2024 14:56
@vickenty vickenty requested review from a team as code owners December 12, 2024 14:56
@@ -34,6 +34,22 @@ qa_agent_jmx:
IMG_SOURCES: ${SRC_AGENT}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-7-jmx-amd64,${SRC_AGENT}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-7-jmx-arm64,${SRC_AGENT}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-7-jmx-win1809-amd64,${SRC_AGENT}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-7-jmx-winltsc2022-amd64
IMG_DESTINATIONS: agent:${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-jmx

qa_agent_fips_jmx:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ question
If you already have tests using it, you should add it to the job that runs them' needs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, there's more work to do before I can use them in tests. I'll make sure I add that when I do add test. Thanks for the heads up.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 12, 2024
@vickenty
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 12, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-12 17:59:39 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 27m.


2024-12-12 18:23:58 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f483cc4 into main Dec 12, 2024
256 checks passed
@dd-mergequeue dd-mergequeue bot deleted the vickenty/fips-jmx-e2e branch December 12, 2024 18:23
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants