Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proto): regenerate protobuf files #32056

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

wdhif
Copy link
Member

@wdhif wdhif commented Dec 11, 2024

What does this PR do?

Re-generate Protobuf files.

Generated using:

datadog@2589fcb93433:~/go/src/github.com/DataDog/datadog-agent$ inv -e generate-protobuf
nuking old definitions at: /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto
generating protobuf code from: /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --go_out=plugins=grpc:/home/datadog/go/src/github.com/DataDog/datadog-agent  /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/model/v1/model.proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --go_out=plugins=grpc:/home/datadog/go/src/github.com/DataDog/datadog-agent  /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/remoteconfig/remoteconfig.proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --go_out=plugins=grpc:/home/datadog/go/src/github.com/DataDog/datadog-agent  /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/api/v1/api.proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --grpc-gateway_out=logtostderr=true:/home/datadog/go/src/github.com/DataDog/datadog-agent /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/api/v1/api.proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --go_out=plugins=grpc:/home/datadog/go/src/github.com/DataDog/datadog-agent  /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/trace/agent_payload.proto /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/trace/stats.proto /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/trace/tracer_payload.proto /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/trace/span.proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --go-vtproto_out=/home/datadog/go/src/github.com/DataDog/datadog-agent --go-vtproto_opt=features=marshal+unmarshal+size /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/trace/agent_payload.proto /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/trace/stats.proto /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/trace/tracer_payload.proto /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/trace/span.proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc-go-inject-tag -input=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/span.pb.go
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc-go-inject-tag -input=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/stats.pb.go
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc-go-inject-tag -input=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/tracer_payload.pb.go
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc-go-inject-tag -input=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/agent_payload.pb.go
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --go_out=plugins=grpc:/home/datadog/go/src/github.com/DataDog/datadog-agent  /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/process/workloadmeta_process.proto /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/process/process.proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --go_out=plugins=grpc:/home/datadog/go/src/github.com/DataDog/datadog-agent  /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/workloadmeta/workloadmeta.proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --go_out=plugins=grpc:/home/datadog/go/src/github.com/DataDog/datadog-agent  /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/languagedetection/api.proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --go_out=plugins=grpc:/home/datadog/go/src/github.com/DataDog/datadog-agent  /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/remoteagent/remoteagent.proto
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && protoc -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto -I/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/protodep --go_out=plugins=grpc:/home/datadog/go/src/github.com/DataDog/datadog-agent  /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/datadog/autodiscovery/autodiscovery.proto
/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/mocks folder already exists
cd /home/datadog/go/src/github.com/DataDog/datadog-agent && mockgen -source=pkg/proto/pbgo/core/api.pb.go -destination=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/mocks/core/api_mockgen.pb.go
msgp -file /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/trace.go -o=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/trace_gen.go -io=False
msgp -file /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/span.pb.go -o=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/span_gen.go -io=False
msgp -file /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/stats.pb.go -o=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/stats_gen.go -io=True
msgp -file /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/tracer_payload.pb.go -o=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/tracer_payload_gen.go -io=False
msgp -file /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/agent_payload.pb.go -o=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace/agent_payload_gen.go -io=False
msgp -file /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/core/remoteconfig.pb.go -o=/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/core/remoteconfig_gen.go -io=False
git apply -p4 --unsafe-paths --directory='/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace' /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/patches/0001-Customize-msgpack-parsing.patch
git apply -p4 --unsafe-paths --directory='/home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace' /home/datadog/go/src/github.com/DataDog/datadog-agent/pkg/proto/patches/0002-Make-nil-map-deserialization-retrocompatible.patch

Motivation

This is needed to avoid having another unrelated PR modifying all the protobuf files.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/agent-apm trace-agent long review PR is complex, plan time to review it labels Dec 11, 2024
@wdhif wdhif added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Dec 11, 2024
Copy link

cit-pr-commenter bot commented Dec 11, 2024

Go Package Import Differences

Baseline: 81ca6f9
Comparison: 6216d1a

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
agentlinuxarm64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
agentwindowsamd64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
agentdarwinamd64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
agentdarwinarm64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
iot-agentlinuxamd64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
iot-agentlinuxarm64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
heroku-agentlinuxamd64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
serverlesslinuxamd64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
serverlesslinuxarm64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
trace-agentlinuxamd64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
trace-agentlinuxarm64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
trace-agentwindowsamd64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
trace-agentdarwinamd64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
trace-agentdarwinarm64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers
heroku-trace-agentlinuxamd64
+1, -0
+github.com/planetscale/vtprotobuf/protohelpers

@wdhif wdhif force-pushed the dev/wassim.dhif/regenerate-protobuf branch 3 times, most recently from 5d9dc6e to 1ea9686 Compare December 11, 2024 17:49
@wdhif wdhif marked this pull request as ready for review December 11, 2024 17:49
@wdhif wdhif requested review from a team as code owners December 11, 2024 17:49
@wdhif wdhif requested a review from a team December 11, 2024 17:49
@wdhif wdhif requested a review from a team as a code owner December 11, 2024 17:49
@wdhif wdhif requested review from IbraheemA and hush-hush December 11, 2024 17:49
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 11, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51054116 --os-family=ubuntu

Note: This applies to commit 6216d1a

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 11, 2024

Package size comparison

Comparison with ancestor 81ca6f9b6f767da2ac185e00beeca7caa28580e2

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1268.87MB 1268.87MB 140.00MB
datadog-iot-agent-amd64-deb -0.00MB 113.28MB 113.28MB 10.00MB
datadog-dogstatsd-amd64-deb -0.00MB 78.52MB 78.52MB 10.00MB
datadog-heroku-agent-amd64-deb 0.01MB ⚠️ 505.42MB 505.42MB 70.00MB
datadog-agent-x86_64-rpm 0.00MB ⚠️ 1278.10MB 1278.10MB 140.00MB
datadog-agent-x86_64-suse 0.00MB ⚠️ 1278.10MB 1278.10MB 140.00MB
datadog-iot-agent-x86_64-rpm -0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-suse -0.00MB 113.35MB 113.35MB 10.00MB
datadog-dogstatsd-x86_64-rpm -0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-x86_64-suse -0.00MB 78.59MB 78.59MB 10.00MB
datadog-agent-arm64-deb -0.00MB 1003.94MB 1003.94MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB ⚠️ 108.76MB 108.76MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.74MB 55.74MB 10.00MB
datadog-agent-aarch64-rpm -0.00MB 1013.15MB 1013.16MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB ⚠️ 108.83MB 108.83MB 10.00MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Dec 11, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 685d5cd1-81e4-4cfa-9427-9ff81e81d907

Baseline: 81ca6f9
Comparison: 6216d1a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.91 [+0.17, +1.64] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.80 [+0.73, +0.86] 1 Logs
quality_gate_idle memory utilization +0.65 [+0.60, +0.70] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput +0.49 [-0.17, +1.14] 1 Logs
quality_gate_logs % cpu utilization +0.12 [-2.83, +3.07] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.06 [-0.58, +0.69] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.73, +0.82] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.84, +0.83] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.78, +0.76] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.75, +0.74] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.88, +0.84] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.80, +0.75] 1 Logs
quality_gate_idle_all_features memory utilization -0.32 [-0.44, -0.20] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.39 [-0.85, +0.08] 1 Logs
file_tree memory utilization -0.52 [-0.65, -0.40] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_300ms_latency lost_bytes 8/10
quality_gate_idle memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@wdhif wdhif force-pushed the dev/wassim.dhif/regenerate-protobuf branch from 1ea9686 to 593d1da Compare December 12, 2024 10:03
Copy link
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for OTel

Signed-off-by: Wassim DHIF <wassim.dhif@datadoghq.com>
@wdhif wdhif force-pushed the dev/wassim.dhif/regenerate-protobuf branch from 593d1da to 4437e36 Compare December 12, 2024 15:50
@wdhif
Copy link
Member Author

wdhif commented Dec 13, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 13, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-13 09:25:03 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-13 11:51:28 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 28m.


2024-12-13 13:57:22 UTC ℹ️ MergeQueue: This merge request was merged

@wdhif wdhif requested a review from a team as a code owner December 13, 2024 10:04
@dd-mergequeue dd-mergequeue bot merged commit db48294 into main Dec 13, 2024
399 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dev/wassim.dhif/regenerate-protobuf branch December 13, 2024 13:57
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants