Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/cyphar/filepath-securejoin from 0.3.4 to 0.3.5 #31916

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2024

Bumps github.com/cyphar/filepath-securejoin from 0.3.4 to 0.3.5.

Release notes

Sourced from github.com/cyphar/filepath-securejoin's releases.

v0.3.5

This release primarily includes a fix for an issue involving two programs racing to MkdirAll the same directory, which caused a regression with BuildKit.

  • MkdirAll will now no longer return an EEXIST error if two racing processes are creating the same directory. We will still verify that the path is a directory, but this will avoid spurious errors when multiple threads or programs are trying to MkdirAll the same path. opencontainers/runc#4543

Signed-off-by: Aleksa Sarai cyphar@cyphar.com

Changelog

Sourced from github.com/cyphar/filepath-securejoin's changelog.

[0.3.5] - 2024-12-06

Fixed

  • MkdirAll will now no longer return an EEXIST error if two racing processes are creating the same directory. We will still verify that the path is a directory, but this will avoid spurious errors when multiple threads or programs are trying to MkdirAll the same path. opencontainers/runc#4543
Commits
  • e60739b VERSION: release v0.3.5
  • bf13132 deps: update to golang.org/x/sys@v0.28.0
  • d9a53cf merge #35 into cyphar/filepath-securejoin:main
  • 31cb517 mkdir: add racing MkdirAll test
  • 72283a0 mkdir: do not error out with -EEXIST for racing MkdirAlls
  • f5bd631 gha: bump go test timeout to 30m
  • 17264db merge #33 into cyphar/filepath-securejoin:main
  • fb7116a VERSION: back to development
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Dec 9, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 9, 2024
@github-actions github-actions bot requested review from a team as code owners December 9, 2024 20:37
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 9, 2024

Package size comparison

Comparison with ancestor 7bb71f7d8f83859af3bf72ce86d14fb40b9bd80b

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb -1.40MB 1268.87MB 1270.27MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.28MB 113.28MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.52MB 78.52MB 10.00MB
datadog-heroku-agent-amd64-deb -1.40MB 505.42MB 506.82MB 70.00MB
datadog-agent-x86_64-rpm -1.41MB 1278.10MB 1279.50MB 140.00MB
datadog-agent-x86_64-suse -1.41MB 1278.10MB 1279.50MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.35MB 113.35MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.59MB 78.59MB 10.00MB
datadog-agent-arm64-deb -1.40MB 1003.94MB 1005.35MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.76MB 108.76MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.74MB 55.74MB 10.00MB
datadog-agent-aarch64-rpm -1.41MB 1013.16MB 1014.56MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.83MB 108.83MB 10.00MB

Decision

✅ Passed

@paulcacheux
Copy link
Contributor

@dependabot recreate

Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.4 to 0.3.5.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases)
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md)
- [Commits](cyphar/filepath-securejoin@v0.3.4...v0.3.5)

---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cyphar/filepath-securejoin-0.3.5 branch from 5a7e5d9 to 1107d0b Compare December 13, 2024 08:36
@paulcacheux paulcacheux removed request for a team December 13, 2024 08:37
@paulcacheux paulcacheux removed request for a team and ankitpatel96 December 13, 2024 08:37
@paulcacheux paulcacheux added team/agent-shared-components qa/done QA done before merge and regressions are covered by tests and removed team/triage labels Dec 13, 2024
@paulcacheux
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 13, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-13 08:38:17 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-13 10:38:41 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

Copy link

cit-pr-commenter bot commented Dec 13, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3383bf7f-a88c-41ff-9535-e0a847427113

Baseline: 7bb71f7
Comparison: 06ff08a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.76 [+1.02, +2.49] 1 Logs
quality_gate_logs % cpu utilization +0.79 [-2.18, +3.76] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.22 [-0.56, +1.00] 1 Logs
file_tree memory utilization +0.19 [+0.06, +0.31] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.11 [-0.66, +0.88] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.75, +0.84] 1 Logs
quality_gate_idle memory utilization +0.03 [-0.02, +0.07] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
quality_gate_idle_all_features memory utilization -0.00 [-0.11, +0.10] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput -0.04 [-0.90, +0.83] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.79, +0.70] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.05 [-0.68, +0.58] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.09 [-0.97, +0.78] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.14 [-0.61, +0.32] 1 Logs
otel_to_otel_logs ingress throughput -0.28 [-0.94, +0.38] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.82 [-1.91, -1.74] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http1 lost_bytes 8/10
file_to_blackhole_500ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@paulcacheux
Copy link
Contributor

/remove

@dd-devflow
Copy link

dd-devflow bot commented Dec 13, 2024

Devflow running: /remove

View all feedbacks in Devflow UI.


2024-12-13 10:38:40 UTC ℹ️ Devflow: /remove

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 13, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 23, 2024

A newer version of github.com/cyphar/filepath-securejoin exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants