Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send device scan status #31894

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Send device scan status #31894

wants to merge 7 commits into from

Conversation

NouhaManai96
Copy link
Contributor

@NouhaManai96 NouhaManai96 commented Dec 9, 2024

What does this PR do?

Add and send a device scan status

Motivation

Add a status to track the progression of the device scan

Describe how you validated your changes

The PR is coupled with this PR that updates our backend to ingest and store the scan status data.
To test, start a scan on one of the devices and make sure that the intake received the expected scan status (you can use logs for that).

Possible Drawbacks / Trade-offs

Additional Notes

@NouhaManai96 NouhaManai96 added the qa/rc-required Only for a PR that requires validation on the Release Candidate label Dec 12, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 12, 2024

Package size comparison

Comparison with ancestor f483cc4c0dffec6f7bcd4824dc8df65c15957e27

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.05MB ⚠️ 1265.99MB 1265.94MB 140.00MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 113.29MB 113.28MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.52MB 78.52MB 10.00MB
datadog-heroku-agent-amd64-deb 0.07MB ⚠️ 502.56MB 502.50MB 70.00MB
datadog-agent-x86_64-rpm 0.07MB ⚠️ 1275.25MB 1275.18MB 140.00MB
datadog-agent-x86_64-suse 0.07MB ⚠️ 1275.25MB 1275.18MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 113.36MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 113.36MB 113.35MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.59MB 78.59MB 10.00MB
datadog-agent-arm64-deb 0.05MB ⚠️ 1001.07MB 1001.02MB 140.00MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 108.77MB 108.76MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.74MB 55.74MB 10.00MB
datadog-agent-aarch64-rpm 0.08MB ⚠️ 1010.31MB 1010.24MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 108.84MB 108.83MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 12, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51605395 --os-family=ubuntu

Note: This applies to commit 1cc608e

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1d74cf41-22e4-4a16-8131-6158deac3086

Baseline: f483cc4
Comparison: 4a6fe7d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.72 [-1.25, +4.68] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.41 [-0.39, +1.21] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.17 [-0.61, +0.95] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.09 [-0.72, +0.91] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.09 [-0.79, +0.97] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.70, +0.74] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.11, +0.07] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.05 [-0.82, +0.72] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.21 [-0.84, +0.42] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.25 [-0.72, +0.22] 1 Logs
quality_gate_idle_all_features memory utilization -0.36 [-0.47, -0.25] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.63 [-0.67, -0.58] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.98 [-1.05, -0.92] 1 Logs
file_tree memory utilization -1.14 [-1.25, -1.02] 1 Logs
otel_to_otel_logs ingress throughput -1.42 [-2.10, -0.74] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.54 [-2.25, -0.83] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@NouhaManai96 NouhaManai96 marked this pull request as ready for review December 13, 2024 09:47
@NouhaManai96 NouhaManai96 requested a review from a team as a code owner December 13, 2024 09:47
cmd/agent/subcommands/snmp/command.go Outdated Show resolved Hide resolved
@NouhaManai96
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 20, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-20 09:14:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-20 13:14:47 UTC ⚠️ MergeQueue: This merge request was unqueued

nouha.manai@datadoghq.com unqueued this merge request: It did not become mergeable within the expected time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/rc-required Only for a PR that requires validation on the Release Candidate team/ndm-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants