[CONTINT-4295][KSM] Add capability to monitor custom resources #31715

L3n41c · 2024-12-03T15:54:11Z

What does this PR do?

Add the capability in kubernetes_state_core check to monitor custom resources.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

…atadog-agent into lenaic/CONTINT-4295

cit-pr-commenter · 2024-12-20T09:22:24Z

Go Package Import Differences

Baseline: 72c4da4
Comparison: 35e7dfa

binary	os	arch	change
agent	linux	amd64	+4, -0 +github.com/gobuffalo/flect +k8s.io/kube-state-metrics/v2/pkg/customresourcestate +k8s.io/kube-state-metrics/v2/pkg/discovery +k8s.io/kube-state-metrics/v2/pkg/metricshandler
agent	linux	arm64	+4, -0 +github.com/gobuffalo/flect +k8s.io/kube-state-metrics/v2/pkg/customresourcestate +k8s.io/kube-state-metrics/v2/pkg/discovery +k8s.io/kube-state-metrics/v2/pkg/metricshandler
agent	windows	amd64	+4, -0 +github.com/gobuffalo/flect +k8s.io/kube-state-metrics/v2/pkg/customresourcestate +k8s.io/kube-state-metrics/v2/pkg/discovery +k8s.io/kube-state-metrics/v2/pkg/metricshandler
agent	darwin	amd64	+4, -0 +github.com/gobuffalo/flect +k8s.io/kube-state-metrics/v2/pkg/customresourcestate +k8s.io/kube-state-metrics/v2/pkg/discovery +k8s.io/kube-state-metrics/v2/pkg/metricshandler
agent	darwin	arm64	+4, -0 +github.com/gobuffalo/flect +k8s.io/kube-state-metrics/v2/pkg/customresourcestate +k8s.io/kube-state-metrics/v2/pkg/discovery +k8s.io/kube-state-metrics/v2/pkg/metricshandler
cluster-agent	linux	amd64	+4, -0 +github.com/gobuffalo/flect +k8s.io/kube-state-metrics/v2/pkg/customresourcestate +k8s.io/kube-state-metrics/v2/pkg/discovery +k8s.io/kube-state-metrics/v2/pkg/metricshandler
cluster-agent	linux	arm64	+4, -0 +github.com/gobuffalo/flect +k8s.io/kube-state-metrics/v2/pkg/customresourcestate +k8s.io/kube-state-metrics/v2/pkg/discovery +k8s.io/kube-state-metrics/v2/pkg/metricshandler

…naic/CONTINT-4295

agent-platform-auto-pr · 2024-12-20T11:27:53Z

Uncompressed package size comparison

Comparison with ancestor 72c4da4652d12a4595eddd8fb4a4372b69184b6a

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-x86_64-rpm	0.26MB	⚠️	1197.41MB	1197.15MB	140.00MB
datadog-agent-x86_64-suse	0.26MB	⚠️	1197.41MB	1197.15MB	140.00MB
datadog-agent-amd64-deb	0.26MB	⚠️	1188.15MB	1187.89MB	140.00MB
datadog-agent-aarch64-rpm	0.17MB	⚠️	943.30MB	943.13MB	140.00MB
datadog-agent-arm64-deb	0.17MB	⚠️	934.05MB	933.89MB	140.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.57MB	78.57MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.64MB	78.64MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.64MB	78.64MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.77MB	55.77MB	10.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.32MB	113.32MB	10.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.39MB	113.39MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.39MB	113.39MB	10.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.79MB	108.79MB	10.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.86MB	108.86MB	10.00MB
datadog-heroku-agent-amd64-deb	-1.40MB	✅	504.86MB	506.26MB	70.00MB

Decision

⚠️ Warning

agent-platform-auto-pr · 2024-12-20T11:29:05Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51667799 --os-family=ubuntu

Note: This applies to commit 35e7dfa

cit-pr-commenter · 2024-12-20T11:53:05Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ff71c6c8-8baa-4413-b325-2eac424d330d

Baseline: 72c4da4
Comparison: ead2539
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+1.77	[+1.70, +1.84]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.08	[+0.39, +1.76]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.34	[-0.45, +1.14]	1	Logs
➖	otel_to_otel_logs	ingress throughput	+0.16	[-0.54, +0.86]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.05	[-0.84, +0.93]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.03	[-0.74, +0.81]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.03	[-0.83, +0.90]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.70, +0.75]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.02	[-0.62, +0.66]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.89, +0.87]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.14, +0.09]	1	Logs
➖	file_tree	memory utilization	-0.08	[-0.22, +0.05]	1	Logs
➖	quality_gate_idle	memory utilization	-0.17	[-0.21, -0.14]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.19	[-0.28, -0.11]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.33	[-0.79, +0.14]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.71	[-3.93, +2.51]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

AliDatadog and others added 6 commits May 29, 2024 15:16

Add capability to monitor custom resources

2205e52

Merge branch 'main' into ali/ksm-custom-resources

38aae6e

Merge branch 'ali/ksm-custom-resources' of ssh://github.com/DataDog/d…

bfd4549

…atadog-agent into lenaic/CONTINT-4295

Fix use of customresourcestate.FromConfig

cce8ef9

fixup! Fix use of customresourcestate.FromConfig

5f35659

Fix the custom resource collection

cfb320f

L3n41c added team/containers qa/done QA done before merge and regressions are covered by tests labels Dec 3, 2024

L3n41c added this to the 7.62.0 milestone Dec 3, 2024

Fix unit tests

94ff88d

L3n41c added 2 commits December 20, 2024 10:37

Run inv generate-licenses

5b1beaa

Fix linter errors

336e2bb

github-actions bot added the medium review PR review might take time label Dec 20, 2024

Merge branch 'main' of ssh://github.com/DataDog/datadog-agent into le…

ead2539

…naic/CONTINT-4295

L3n41c force-pushed the lenaic/CONTINT-4295 branch from 17ab062 to ead2539 Compare December 20, 2024 10:56

L3n41c mentioned this pull request Dec 20, 2024

Add KSM configuration to collect DatadogMetric DataDog/test-infra-definitions#1320

Open

Add end-to-end tests

35e7dfa

github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CONTINT-4295][KSM] Add capability to monitor custom resources #31715

[CONTINT-4295][KSM] Add capability to monitor custom resources #31715

L3n41c commented Dec 3, 2024

cit-pr-commenter bot commented Dec 20, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 20, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 20, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 20, 2024

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

[CONTINT-4295][KSM] Add capability to monitor custom resources #31715

Are you sure you want to change the base?

[CONTINT-4295][KSM] Add capability to monitor custom resources #31715

Conversation

L3n41c commented Dec 3, 2024

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter bot commented Dec 20, 2024 • edited Loading

Go Package Import Differences

agent-platform-auto-pr bot commented Dec 20, 2024 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Dec 20, 2024 • edited Loading

Test changes on VM

cit-pr-commenter bot commented Dec 20, 2024

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

cit-pr-commenter bot commented Dec 20, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 20, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 20, 2024 •

edited

Loading