Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/bhmj/jsonslice from 0.0.0-20200323023432-92c3edaad8e2 to 1.1.3 #28033

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 29, 2024

Bumps github.com/bhmj/jsonslice from 0.0.0-20200323023432-92c3edaad8e2 to 1.1.3.

Release notes

Sourced from github.com/bhmj/jsonslice's releases.

v.1.1.3: fix "spaces after object" bug

  • Fixed a bug which resulted in error when called on sparsed JSON with some spaces/tabs after closing '}'

v1.1.2: unicode support + bugfixes

  • added Unicode support (\u and \U)
  • added hex support (\x)
  • indexing of elements in expression fixed (@[5])
  • escaped backslash bug fixed (["\\"])

v1.1.1: updated xpression

  • xpression package updated to v0.9.0

v1.1.0: expressions improved

  • use xpression project for expression evaluation
  • new operators introduced: !, %, **, <<, >>, ~, |, &, ^
  • minor optimizations

v1.0.6: Comparison improved

  • abstract and strict comparison (== and === behave like in JavaScript)
  • cross-typed string/number/boolean comparison
  • strings are now comparable

$..many.keys bugfix

deepscan issue fix: $..many.keys used to trigger on many without recursing deeper on keys.

$* bugfix

  • fixed crash on $* path

Escaped backslash bugfix

"\\" at the end of string

Nested aggregation

  • nested aggregation ($[:].['a','b']) now works as expected ([ [...], [...] ])

"not equal" for regexp

  • "not equal" operator added for regexp: !~ or !=~

Production ready

  • refined logic
  • improved tests
  • deepscan operator added
  • slice with step added
  • syntax extensions added

Escaped backslash bugfix

  • "\\" -- this string caused parser to miss the end of string value.

Functions work in filter

  • functions count(), size(), length() now work in filters

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [github.com/bhmj/jsonslice](https://github.com/bhmj/jsonslice) from 0.0.0-20200323023432-92c3edaad8e2 to 1.1.3.
- [Release notes](https://github.com/bhmj/jsonslice/releases)
- [Commits](https://github.com/bhmj/jsonslice/commits/v1.1.3)

---
updated-dependencies:
- dependency-name: github.com/bhmj/jsonslice
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Jul 29, 2024
Copy link

cit-pr-commenter bot commented Jul 29, 2024

Go Package Import Differences

Baseline: 561fc3e
Comparison: 6c4ff64

binaryosarchchange
cluster-agentlinuxamd64
+1, -0
+github.com/bhmj/xpression
cluster-agentlinuxarm64
+1, -0
+github.com/bhmj/xpression
cluster-agent-cloudfoundrylinuxamd64
+1, -0
+github.com/bhmj/xpression
cluster-agent-cloudfoundrylinuxarm64
+1, -0
+github.com/bhmj/xpression

@pr-commenter
Copy link

pr-commenter bot commented Jul 29, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3d207f84-7a29-4556-a4db-9910c1c00a59

Baseline: 561fc3e
Comparison: 6c4ff64
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +0.95 [-2.32, +4.22] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.43 [+0.38, +0.49] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.32 [-0.36, +0.99] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.23 [-0.23, +0.69] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.13 [-0.63, +0.89] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.76, +0.79] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.73, +0.76] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.64, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.88, +0.88] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.11, +0.10] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.91, +0.89] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.85, +0.82] 1 Logs
quality_gate_idle memory utilization -0.24 [-0.27, -0.20] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.36 [-0.44, -0.28] 1 Logs bounds checks dashboard
file_tree memory utilization -0.51 [-0.64, -0.38] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_500ms_latency lost_bytes 7/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@AliDatadog AliDatadog added team/container-platform The Container Platform Team and removed team/triage labels Oct 18, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 24, 2024
@wdhif wdhif added team/platform-integrations and removed team/container-platform The Container Platform Team labels Dec 24, 2024
@wdhif
Copy link
Member

wdhif commented Dec 24, 2024

To @DataDog/platform-integrations as they are code owners of comp/core/autodiscovery/providers/cloudfoundry.go which is using github.com/bhmj/jsonslice

Copy link
Member

@NouemanKHAL NouemanKHAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, the unit tests are able to catch if there was any breaking changes.

@NouemanKHAL NouemanKHAL added the qa/done QA done before merge and regressions are covered by tests label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/platform-integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants