Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Tooling] Remove bench invoke collection #21397

Merged
merged 5 commits into from
Dec 7, 2023
Merged

[CI/Tooling] Remove bench invoke collection #21397

merged 5 commits into from
Dec 7, 2023

Conversation

amenasria
Copy link
Contributor

What does this PR do?

This PR:

  • Removes the dogstatsd and aggregator benchmarks-related invoke tasks.
  • Removes the kubernetes-state benchmarks-related invoke tasks.
  • Removes the now empty bench invoke collection.

Motivation

These are not used anymore. For example dogstatsd benchmarks are now in https://github.com/DataDog/datadog-agent-benchmarks.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@amenasria amenasria added changelog/no-changelog [deprecated] team/agent-platform [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Dec 7, 2023
@amenasria amenasria added this to the 7.51.0 milestone Dec 7, 2023
@amenasria amenasria requested review from a team as code owners December 7, 2023 13:25
Pythyu
Pythyu approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@Pythyu Pythyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pr-commenter
Copy link

pr-commenter bot commented Dec 7, 2023 •
edited
Loading

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: e5f7f9e5-05b4-45a7-894b-1767436c4e2a
Baseline: 8d536e5
Comparison: 2c8d865
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ denotes better comparison variant performance
  • ❌ denotes worse comparison variant performance

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Declared stable experiments that are now erratic

An experiment is erratic (i.e., not stable) if its coefficient of variation is at least 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
✅ otel_to_otel_logs ingress throughput +0.22 [-0.46, +0.91] 40.99%

Experiments with missing or malformed data

  • idle
  • tcp_dd_logs_filter_exclude

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI confidence
✅ otel_to_otel_logs ingress throughput +0.22 [-0.46, +0.91] 40.99%
✅ file_to_blackhole egress throughput +0.13 [-6.03, +6.30] 2.85%
❌ dogstatsd_string_interner_8MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
❌ dogstatsd_string_interner_8MiB_10k ingress throughput +0.00 [-0.00, +0.00] 0.00%
❌ dogstatsd_string_interner_64MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
❌ dogstatsd_string_interner_8MiB_50k ingress throughput +0.00 [-0.00, +0.00] 0.00%
❌ dogstatsd_string_interner_8MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
❌ dogstatsd_string_interner_64MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
❌ trace_agent_json ingress throughput +0.00 [-0.01, +0.01] 0.00%
❌ uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 0.00%
❌ dogstatsd_string_interner_128MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
❌ dogstatsd_string_interner_128MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
❌ trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00] 0.00%
❌ dogstatsd_string_interner_8MiB_100k ingress throughput -0.00 [-0.00, +0.00] 3.28%
❌ tcp_syslog_to_blackhole ingress throughput -0.02 [-0.07, +0.04] 36.62%
❌ file_tree egress throughput -0.26 [-2.05, +1.53] 18.84%

Revert "Remove bench.build-kubernetes-state and bench.kubernetes_stat…
2c8d865 
…e invoke tasks as well as bench collection"

This reverts commit 3ff1e0e.
@amenasria amenasria removed the request for review from a team December 7, 2023 16:54
@amenasria
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 7, 2023

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

you can cancel this operation by commenting your pull request with /merge -c!

@dd-devflow
Copy link

dd-devflow bot commented Dec 7, 2023

🚂 MergeQueue

Added to the queue.

There are 6 builds ahead of this PR! (estimated merge in less than 1h)

you can cancel this operation by commenting your pull request with /merge -c!

@dd-mergequeue dd-mergequeue bot merged commit 9722080 into main Dec 7, 2023
16 checks passed
@dd-mergequeue dd-mergequeue bot deleted the amenasria/remove-bench-invoke-collection branch December 7, 2023 19:11
@mx-psi mx-psi mentioned this pull request Dec 13, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pythyu Pythyu Pythyu approved these changes

@vickenty vickenty vickenty approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-platform mergequeue-status: done
Projects
None yet
Milestone
7.51.0
Development

Successfully merging this pull request may close these issues.
3 participants
@amenasria @vickenty @Pythyu