Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI test suites #816

Merged
merged 6 commits into from
Sep 8, 2021
Merged

Update CircleCI test suites #816

merged 6 commits into from
Sep 8, 2021

Conversation

KSerrania
Copy link
Contributor

@KSerrania KSerrania commented Sep 7, 2021

What does this PR do?

Adds spec tests for Ruby 2.7 and 3.0, as well as Chef 17.

This requires installing a newer version of rvm, because the default version present in the image doesn't know Ruby 3.0.

Updates the tests to be compatible with Ruby 3.0:

  • the fauxhai gem had to be updated to 8.3.1 to include this fix: Resolve warning about usage of URI.open chefspec/fauxhai#351, without which the tests fail (because open alone can only refer to File.open, not URI.open in Ruby 3.0)
  • the fauxhai gem update deprecated a bunch of platforms: Fedora 26 & 27, Debian 7.11 and 8.9. They have been replaced with Fedora 31 & 32, Debian 8.11.
  • the Fedora platforms update required some changes in tests, as these versions use dnf_package and not yum_package.

Updates the tests & rake tasks to be compatible with Chef 17:

  • in Chef 17, the zypper_repository resource automatically transforms the gpgkey entry into an array. The corresponding test had to be modified to take the Chef >= 17 and Chef < 17 cases into account.
  • some chef modules used in release rake tasks have disappeared. As a temporary workaround, these are lazy-loaded so that they don't make Chef 17 CI tests fail.

@KSerrania KSerrania force-pushed the kserrania/add-chef-3 branch 14 times, most recently from a7660cc to dac4385 Compare September 7, 2021 15:45
@KSerrania KSerrania force-pushed the kserrania/add-chef-3 branch from dac4385 to 8340828 Compare September 7, 2021 15:50
@KSerrania KSerrania force-pushed the kserrania/add-chef-3 branch 4 times, most recently from acf1253 to 6a120fc Compare September 7, 2021 18:32
@KSerrania KSerrania force-pushed the kserrania/add-chef-3 branch from 6a120fc to 39266d2 Compare September 7, 2021 18:35
@KSerrania KSerrania marked this pull request as ready for review September 7, 2021 19:02
@KSerrania KSerrania requested a review from a team as a code owner September 7, 2021 19:02
@KSerrania KSerrania merged commit 623eb2b into main Sep 8, 2021
@KSerrania KSerrania deleted the kserrania/add-chef-3 branch September 8, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants