Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.18.0 #589

Merged
merged 5 commits into from
Mar 18, 2019
Merged

Release 2.18.0 #589

merged 5 commits into from
Mar 18, 2019

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Mar 12, 2019

No description provided.

@remeh remeh added this to the 2.18.0 milestone Mar 12, 2019
@remeh remeh self-assigned this Mar 12, 2019
@remeh remeh force-pushed the remeh/release-2_18_0 branch from f7d0380 to 37107e3 Compare March 12, 2019 13:29
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to :shipit: as soon as the CI is 💚

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, other than that LGTM

CHANGELOG.md Outdated
@@ -1,11 +1,22 @@
Changes
=======

# 2.18.0 / 2019-03-12

**Note for Windows users**: since Agent v6.11, chef-datadog `>= 2.18.0` is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, I'd write:

to install v6.11+ of the Windows Agent, datadog >=2.18.0 is required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@remeh remeh merged commit 02b51ae into master Mar 18, 2019
@remeh remeh deleted the remeh/release-2_18_0 branch March 18, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants