Add support for multiple tags via key/value #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide the ability to add tags on different attribute levels. Chef will merge the attributes together and the template will generate the list from them. To "remove" a tag on a higher precedence level, set it to an empty string.
1 similar comment
|
@lightpriest Getting back to this feature now. Looks like it can't be merged - there might be a conflict in the datadog.conf somewhere. Also, is there any tests you might write with ChefSpec to validate the template outcome of passing in the tags attribute? |
added 2 commits
July 22, 2015 21:04
Mainly to avoid creating another pull-request
|
@miketheman I added a spec for this, imitating the structure of the other specs. I also tried to add a commit that would fix the merge conflict, but I guess it wasn't enough. The conflict is in a comment section in |
|
+1 for this! |
|
Closing, as superseded with #296 Thanks for the contribution! |
miketheman
pushed a commit
that referenced
this pull request
Apr 21, 2016
* Extract datadog tags into a template var * Support strings and hashes * Update docs for tag attribute * Add test coverage for tags (string, hash, empty hash value) Closes #186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new pull request (previous is #183) without a version change and with a more strict test for Hash implementation.
Enables setting tags from different attribute levels, backward compatible.
Suppose you have role A which acts on two environments B and C.
This patch enables setting this on the role:
And these on the different environments:
Will result in datadog.conf having
tags: cluster:A,environment:Bandtags: cluster:A,environment:Crespectively. String version of the tags should still work. To remove a tag in a higher precedence level, set it to an empty string.This is also reported in #170.