Allow users to set a custom user/password to run the Windows Datadog Agent service. #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekwbrown
approved these changes
May 20, 2019
remeh
added a commit
that referenced
this pull request
May 21, 2019
Allow users to set a custom user/password to run the Windows Datadog Agent service.
olivielpeau
reviewed
May 21, 2019
| # a specific user instead of LOCAL_SYSTEM, check whether the user has provided | ||
| # custom credentials and use them if that's the case. | ||
| install_options.concat(' DDAGENTUSER_NAME=').concat(Chef::Datadog.ddagentuser_name(node)) if Chef::Datadog.ddagentuser_name(node) | ||
| install_options.concat(' DDAGENTUSER_PASSWORD=').concat(Chef::Datadog.ddagentuser_password(node)) if Chef::Datadog.ddagentuser_password(node) |
There was a problem hiding this comment.
is there a chance that there are special characters in the name or password that may need to be escaped/quoted when passed through the command line?
There was a problem hiding this comment.
I've tested a password with some '"[](){}!-=/\#~. so I think we're fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the user of the cookbook provide custom credentials for the Datadog Agent service. It only makes sense for Agents >=
6.11.0(the feature appeared in the Agent in6.11.0).Note that this PR targets
v2.xand will later be cherry-picked inmasterfor 3.x versions