Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the 'docker' group exists, append the 'dd-agent' user to it #364

Merged
merged 2 commits into from
Sep 22, 2016
Merged

If the 'docker' group exists, append the 'dd-agent' user to it #364

merged 2 commits into from
Sep 22, 2016

Conversation

jvrplmlmn
Copy link
Contributor

Closes #363

@jvrplmlmn jvrplmlmn force-pushed the add-ddagent-to-docker-group branch from b278983 to 0c86e86 Compare September 21, 2016 07:41
@jvrplmlmn
Copy link
Contributor Author

@olivielpeau I think that you're an owner of this repository.

olivielpeau
olivielpeau suggested changes Sep 21, 2016
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jvrplmlmn! Your changes look good.

Could you also add a test for this in spec/integrations/docker_daemon_spec.rb?

A test like it { is_expected.to manage_group('docker').with(append: true, members: ['dd-agent']) } should work.

@olivielpeau olivielpeau added this to the 2.7.0 milestone Sep 21, 2016
@jvrplmlmn
Copy link
Contributor Author

CircleCI seems to have failed for an issue non related to this change. Can you rebuild it or do I need to rewrite the commit to trigger it again?

@olivielpeau
Copy link
Member

@jvrplmlmn I've rebuilt the CircleCI job, the tests seem a little flaky there, I'll look into them if the issue persists.

I'll merge as soon as the tests pass. Thanks!

@jvrplmlmn
Copy link
Contributor Author

@olivielpeau Tests are now passing! Any chance that we could have a 2.6.1 version released? Otherwise I'll wait to 2.7.0.

@olivielpeau
Copy link
Member

@jvrplmlmn thanks, merging!

Since this is more an improvement than a bugfix I'd rather release this with the next minor, 2.7.0, once we have enough features ready. You can definitely use your own fork of the cookbook until then, hope that's not too much of a hassle for you.

@olivielpeau olivielpeau merged commit bb01095 into DataDog:master Sep 22, 2016
@jvrplmlmn jvrplmlmn deleted the add-ddagent-to-docker-group branch September 27, 2016 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivielpeau olivielpeau olivielpeau approved these changes

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jvrplmlmn @olivielpeau