Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dns_check support #294

Merged
merged 1 commit into from
May 4, 2016
Merged

Conversation

nickmarden
Copy link
Contributor

No description provided.

@nickmarden
Copy link
Contributor Author

@miketheman Thanks for the needs spec test - I was unclear that individual recipes should be added for individual templates, but I followed my nose and came up with something that seems to have coverage and look like all of the other spec-ified recipes.

@miketheman
Copy link
Contributor

Hi @nickmarden !
Thanks - the spec looks great, it's failing to run due to a linter violation - see https://travis-ci.org/DataDog/chef-datadog/builds/123973389#L254

@nickmarden
Copy link
Contributor Author

Thanks @miketheman - fixed and re-running CI now.

@miketheman miketheman added this to the Next minor milestone May 2, 2016
@miketheman
Copy link
Contributor

Thanks! Added to the merge queue.

@miketheman miketheman merged commit bb0f99c into DataDog:master May 4, 2016
miketheman added a commit that referenced this pull request May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants